Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Console] Fix overflow of editor actions panel (#193714) #193754

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR fixes the bug in Console where, when you scroll an editor
content that contains an editor actions panel, the actions panel would
move to the other panel and would be displayed on top of it, while it
should be hidden.

Before:

https://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3

Now:

https://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed
(cherry picked from commit 80c7583)
@kibanamachine kibanamachine merged commit 3bfb142 into elastic:8.x Sep 23, 2024
26 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / Alerting builtin alertTypes cancellable_rule rule that implements cancellation services throws an error if search runs longer than rule timeout

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 208.1KB 208.0KB -38.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
console 40.2KB 40.2KB -16.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants