Skip to content

Commit

Permalink
[8.x] [Console] Fix overflow of editor actions panel (#193714) (#193754)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Fix overflow of editor actions panel
(#193714)](#193714)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T16:18:48Z","message":"[Console]
Fix overflow of editor actions panel (#193714)\n\n## Summary\r\n\r\nThis
PR fixes the bug in Console where, when you scroll an editor\r\ncontent
that contains an editor actions panel, the actions panel would\r\nmove
to the other panel and would be displayed on top of it, while
it\r\nshould be
hidden.\r\n\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3\r\n\r\n\r\nNow:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed","sha":"80c7583c57db76c0c643fc889fdf6719782a3171","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console]
Fix overflow of editor actions
panel","number":193714,"url":"https://github.com/elastic/kibana/pull/193714","mergeCommit":{"message":"[Console]
Fix overflow of editor actions panel (#193714)\n\n## Summary\r\n\r\nThis
PR fixes the bug in Console where, when you scroll an editor\r\ncontent
that contains an editor actions panel, the actions panel would\r\nmove
to the other panel and would be displayed on top of it, while
it\r\nshould be
hidden.\r\n\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3\r\n\r\n\r\nNow:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed","sha":"80c7583c57db76c0c643fc889fdf6719782a3171"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193714","number":193714,"mergeCommit":{"message":"[Console]
Fix overflow of editor actions panel (#193714)\n\n## Summary\r\n\r\nThis
PR fixes the bug in Console where, when you scroll an editor\r\ncontent
that contains an editor actions panel, the actions panel would\r\nmove
to the other panel and would be displayed on top of it, while
it\r\nshould be
hidden.\r\n\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3\r\n\r\n\r\nNow:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed","sha":"80c7583c57db76c0c643fc889fdf6719782a3171"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <[email protected]>
  • Loading branch information
kibanamachine and ElenaStoeva authored Sep 23, 2024
1 parent 3bf4b47 commit 3bfb142
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ export function Main({ currentTabProp, isEmbeddable = false }: MainProps) {
{currentTab === HISTORY_TAB_ID && <History isVerticalLayout={isVerticalLayout} />}
{currentTab === CONFIG_TAB_ID && <Config isVerticalLayout={isVerticalLayout} />}
</EuiSplitPanel.Inner>
<EuiHorizontalRule margin="none" className="consoleVariablesBottomBar" />
<EuiHorizontalRule margin="none" />
<EuiSplitPanel.Inner
paddingSize="xs"
grow={false}
Expand Down
7 changes: 2 additions & 5 deletions src/plugins/console/public/styles/_app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@
left: 0;
bottom: 0;
right: 0;
}

.consoleVariablesBottomBar {
// Give priority to the variables bar so that it doesn't get covered by the empty prompt when in vertical layout
z-index: $euiZLevel2;
overflow: hidden;
}

.conApp__editor {
Expand Down Expand Up @@ -123,6 +119,7 @@
border-radius: $euiSizeXS;
box-shadow: 0 0 $euiSizeXS $euiSizeXS transparentize($euiShadowColor, .9);
padding-top: $euiSize * .1;
overflow-y: auto;
}

.conApp__editorActions {
Expand Down

0 comments on commit 3bfb142

Please sign in to comment.