[Console] Fix overflow of editor actions panel #193714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Feature:Console
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
commented
Sep 23, 2024
| @@ -29,11 +29,7 @@ | |||
| left: 0; | |||
| bottom: 0; | |||
| right: 0; | |||
| } | |||
|
|
|||
| .consoleVariablesBottomBar { | |||
There was a problem hiding this comment.
This class is not needed anymore after we added the overflow property to the panel.
sabarasaba
approved these changes
Sep 23, 2024
ElenaStoeva
added
backport:prev-minor
|
Thanks for the review @sabarasaba!
Yes, just added the backport label, thanks for the reminder! |
ElenaStoeva
added
backport:prev-minor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
ryankeairns
approved these changes
Sep 23, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
## Summary This PR fixes the bug in Console where, when you scroll an editor content that contains an editor actions panel, the actions panel would move to the other panel and would be displayed on top of it, while it should be hidden. Before: https://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3 Now: https://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed (cherry picked from commit 80c7583)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Console] Fix overflow of editor actions panel (#193714)](#193714) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T16:18:48Z","message":"[Console] Fix overflow of editor actions panel (#193714)\n\n## Summary\r\n\r\nThis PR fixes the bug in Console where, when you scroll an editor\r\ncontent that contains an editor actions panel, the actions panel would\r\nmove to the other panel and would be displayed on top of it, while it\r\nshould be hidden.\r\n\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3\r\n\r\n\r\nNow:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed","sha":"80c7583c57db76c0c643fc889fdf6719782a3171","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console] Fix overflow of editor actions panel","number":193714,"url":"https://github.com/elastic/kibana/pull/193714","mergeCommit":{"message":"[Console] Fix overflow of editor actions panel (#193714)\n\n## Summary\r\n\r\nThis PR fixes the bug in Console where, when you scroll an editor\r\ncontent that contains an editor actions panel, the actions panel would\r\nmove to the other panel and would be displayed on top of it, while it\r\nshould be hidden.\r\n\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3\r\n\r\n\r\nNow:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed","sha":"80c7583c57db76c0c643fc889fdf6719782a3171"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193714","number":193714,"mergeCommit":{"message":"[Console] Fix overflow of editor actions panel (#193714)\n\n## Summary\r\n\r\nThis PR fixes the bug in Console where, when you scroll an editor\r\ncontent that contains an editor actions panel, the actions panel would\r\nmove to the other panel and would be displayed on top of it, while it\r\nshould be hidden.\r\n\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e29640cc-8ce3-4b5b-bbb6-ca6a5ce86ff3\r\n\r\n\r\nNow:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/25b3aa41-4ad0-48f7-925c-c5f354f551ed","sha":"80c7583c57db76c0c643fc889fdf6719782a3171"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug in Console where, when you scroll an editor content that contains an editor actions panel, the actions panel would move to the other panel and would be displayed on top of it, while it should be hidden.
Before:
Screen.Recording.2024-09-23.at.13.38.09.mov
Now:
Screen.Recording.2024-09-23.at.13.37.31.mov