-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts #193614
[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts #193614
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6993[❌] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 73/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6992[❌] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 74/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6995[❌] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 64/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6996[✅] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 50/50 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6997[✅] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 200/200 tests passed. |
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const ruleId = createResponse.body.id; | ||
objectRemover.add(Spaces.space1.id, ruleId, 'rule', 'alerting'); | ||
|
||
await waitForExecutionCount(1, ruleId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could probably put these in a for loop :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha that is prob a good idea! Resolved in this commit 2b150c0
…bana into flaky-test/alerting-monitor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…only/tests/alerting/group2/monitoring·ts (elastic#193614) Resolves elastic#193072 ## Summary Removes the skip on flaky monitoring tests (cherry picked from commit cd5ff16)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…paces_only/tests/alerting/group2/monitoring·ts (#193614) (#193785) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts (#193614)](#193614) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexi Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T19:09:40Z","message":"[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts (#193614)\n\nResolves https://github.com/elastic/kibana/issues/193072\r\n\r\n## Summary\r\n\r\nRemoves the skip on flaky monitoring tests","sha":"cd5ff16dfdbc5ff46199f4ce5785bf52da22fa8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts","number":193614,"url":"https://github.com/elastic/kibana/pull/193614","mergeCommit":{"message":"[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts (#193614)\n\nResolves https://github.com/elastic/kibana/issues/193072\r\n\r\n## Summary\r\n\r\nRemoves the skip on flaky monitoring tests","sha":"cd5ff16dfdbc5ff46199f4ce5785bf52da22fa8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193614","number":193614,"mergeCommit":{"message":"[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts (#193614)\n\nResolves https://github.com/elastic/kibana/issues/193072\r\n\r\n## Summary\r\n\r\nRemoves the skip on flaky monitoring tests","sha":"cd5ff16dfdbc5ff46199f4ce5785bf52da22fa8a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexi Doak <[email protected]>
Resolves #193072
Summary
Removes the skip on flaky monitoring tests