Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iframe embed code is not behaving correctly since 8.15 #192980

Closed
yomduf opened this issue Sep 16, 2024 · 3 comments
Closed

Iframe embed code is not behaving correctly since 8.15 #192980

yomduf opened this issue Sep 16, 2024 · 3 comments
Assignees
@tsullivan
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@yomduf
Copy link

yomduf commented Sep 16, 2024

Kibana version: 8.15.1

Elasticsearch version: 8.15.1

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

  • Share dashboard option as Iframe ignore item selected

Steps to reproduce:

  1. Use Kibana sample Dashboard

  2. Click on share and click embed

  3. Select 1 item or nothing
    Image

  4. The dashboard exposed is equivalent to all item selected

Comparaison 8.14.3 vs 8.15.1 with no item selected in both version
Image

Explanation guess :
In 8.15.1 the URL suffix is

?_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A0)%2Ctime%3A(from%3Anow-7d%2Cto%3Anow))&hide-filter-bar=true

where in 8.14.3 it's

?embed=true&_g=()&hide-filter-bar=true

The ?embed=true& is missing in 8.15.1, adding it solve the issue

Expected behavior:
Having an URL that is like this

?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A0)%2Ctime%3A(from%3Anow-7d%2Cto%3Anow))&hide-filter-bar=true

Image

Screenshots (if relevant):

Errors in browser console (if relevant):
No error in browser

Provide logs and/or server output (if relevant):

Any additional context:
@yomduf yomduf added the bug Fixes for quality problems that affect the customer experience label Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@lukasolson lukasolson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Sep 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Sep 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@nreese nreese added regression good first issue low hanging fruit labels Sep 25, 2024
@viajes7 viajes7 mentioned this issue Sep 30, 2024
Merged
@tsullivan
Copy link
Member

Duplicate of #193447

@tsullivan tsullivan marked this as a duplicate of #193447 Sep 30, 2024
@jsanz jsanz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
tsullivan added a commit that referenced this issue Oct 3, 2024
@viajes7 @elasticmachine @tsullivan
[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)
e4ff3bb 
## Summary

Fixes [#192980](#193447)

Maybe related pr: #179037 

After fix it, having an URL that is like this:
```
?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true
```

**Screenshot**
<img width="1918" alt="image"
src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e">

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Tim Sullivan <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 3, 2024
@viajes7
[Dashboard] Fix share dashboard iframe embed code incorrectly (elasti…
30d06a2 
…c#194366)

## Summary

Fixes [elastic#192980](elastic#193447)

Maybe related pr: elastic#179037

After fix it, having an URL that is like this:
```
?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true
```

**Screenshot**
<img width="1918" alt="image"
src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e">

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Tim Sullivan <[email protected]>
(cherry picked from commit e4ff3bb)
kibanamachine added a commit that referenced this issue Oct 3, 2024
@kibanamachine @viajes7
[8.x] [Dashboard] Fix share dashboard iframe embed code incorrectly (#…
c9cb0fa 
…194366) (#194773)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard] Fix share dashboard iframe embed code incorrectly
(#194366)](#194366)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T00:24:46Z","message":"[Dashboard]
Fix share dashboard iframe embed code incorrectly (#194366)\n\n##
Summary\r\n\r\nFixes
[#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe
related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like
this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img
width=\"1918\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Tim
Sullivan
<[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.15.3"],"title":"[Dashboard]
Fix share dashboard iframe embed code
incorrectly","number":194366,"url":"https://github.com/elastic/kibana/pull/194366","mergeCommit":{"message":"[Dashboard]
Fix share dashboard iframe embed code incorrectly (#194366)\n\n##
Summary\r\n\r\nFixes
[#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe
related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like
this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img
width=\"1918\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Tim
Sullivan
<[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194366","number":194366,"mergeCommit":{"message":"[Dashboard]
Fix share dashboard iframe embed code incorrectly (#194366)\n\n##
Summary\r\n\r\nFixes
[#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe
related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like
this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img
width=\"1918\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Tim
Sullivan
<[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jusheng Huang <[email protected]>
tsullivan pushed a commit to tsullivan/kibana that referenced this issue Oct 3, 2024
@viajes7 @tsullivan
[Dashboard] Fix share dashboard iframe embed code incorrectly (elasti…
a694c31 
…c#194366)

## Summary

Fixes [elastic#192980](elastic#193447)

Maybe related pr: elastic#179037

After fix it, having an URL that is like this:
```
?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true
```

**Screenshot**
<img width="1918" alt="image"
src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e">

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Tim Sullivan <[email protected]>
(cherry picked from commit e4ff3bb)

# Conflicts:
#	src/plugins/share/public/components/share_tabs.test.tsx
#	src/plugins/share/public/services/share_menu_manager.tsx
tsullivan added a commit that referenced this issue Oct 4, 2024
@tsullivan @viajes7 @kibanamachine
[8.15] [Dashboard] Fix share dashboard iframe embed code incorrectly (#…
20c068b 
…194366) (#194774)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Dashboard] Fix share dashboard iframe embed code incorrectly
(#194366)](#194366)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T00:24:46Z","message":"[Dashboard]
Fix share dashboard iframe embed code incorrectly (#194366)\n\n##
Summary\r\n\r\nFixes
[#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe
related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like
this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img
width=\"1918\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Tim
Sullivan
<[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.15.3"],"number":194366,"url":"https://github.com/elastic/kibana/pull/194366","mergeCommit":{"message":"[Dashboard]
Fix share dashboard iframe embed code incorrectly (#194366)\n\n##
Summary\r\n\r\nFixes
[#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe
related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like
this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img
width=\"1918\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Tim
Sullivan
<[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194366","number":194366,"mergeCommit":{"message":"[Dashboard]
Fix share dashboard iframe embed code incorrectly (#194366)\n\n##
Summary\r\n\r\nFixes
[#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe
related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like
this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img
width=\"1918\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Tim
Sullivan
<[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/194773","number":194773,"state":"OPEN"},{"branch":"8.15","label":"v8.15.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Jusheng Huang <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@viajes7 @elasticmachine
@tsullivan @tiansivive
[Dashboard] Fix share dashboard iframe embed code incorrectly (elasti…
0e8db6a 
…c#194366)

## Summary

Fixes [elastic#192980](elastic#193447)

Maybe related pr: elastic#179037 

After fix it, having an URL that is like this:
```
?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true
```

**Screenshot**
<img width="1918" alt="image"
src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e">

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Tim Sullivan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsullivan tsullivan

Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jsanz @nreese @tsullivan @lukasolson @elasticmachine @yomduf