-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Promote new inventory plugin in APM #192856
Comments
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
@kpatticha, I have a question about the removal of the link to enable the new experience ('Try our new experience!'). In the acceptance criteria, we state that the "Try our new Inventory!" link should only be displayed if Should we remove it regardless of the inventory view? If not, when |
@iblancof which AC are you referring to? |
Regarding
No, we should not. We'll remove the new service inventory and the user won't have any option to enable/disable this view. In the acceptance I had added the following to ensure the view is always classic.
|
Oh, I see. So what the AC is actually specifying is that whenever I enter the services inventory, I should set I initially understood it the other way around, that the new behavior (showing the new link and removing the old one) would only occur if the inventory view mode was set to 'classic', and no changes were necessary otherwise. @kpatticha, could you please confirm if I got this right? |
Yes! This is in case a user has already switched to the new view (entity), we need to ensure it always defaults to the classic view, as we're removing the option to switch back. Or you can simply remove the condition where we switch to the new multi signal table. Up to you
No, we will remove the "new Service" Inventory in apm. The link will basically point to the new inventory plugin Let me know if you need further clarification. |
## Summary Closes #192856. This PR removes the ability to enable the new APM experience and replaces it with a link promoting the new Inventory feature. ![Screen Recording 2024-09-25 at 15 02 29](https://github.com/user-attachments/assets/5dc6b8af-f207-43e5-8125-fffb4b823e4d) --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Closes elastic#192856. This PR removes the ability to enable the new APM experience and replaces it with a link promoting the new Inventory feature. ![Screen Recording 2024-09-25 at 15 02 29](https://github.com/user-attachments/assets/5dc6b8af-f207-43e5-8125-fffb4b823e4d) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9f9d911)
Summary
Remove the functionality to enable the new experience in APM and replace it with the a link to promote the new inventory. The
Designs
Acceptance criteria
apm.service.inventory.view
local storage should be 'classic'kibana/x-pack/plugins/observability_solution/apm/public/components/routing/templates/custom_no_data_template.tsx
Line 51 in 8d8742f
observability:entityCentricExperience
advanced setting is enabledThe text was updated successfully, but these errors were encountered: