Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Promote new inventory plugin in APM #192856

Closed
kpatticha opened this issue Sep 13, 2024 · 6 comments · Fixed by #193997
Closed

[APM] Promote new inventory plugin in APM #192856

kpatticha opened this issue Sep 13, 2024 · 6 comments · Fixed by #193997
Assignees
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@kpatticha
Copy link
Contributor

kpatticha commented Sep 13, 2024

Summary

Remove the functionality to enable the new experience in APM and replace it with the a link to promote the new inventory. The

Designs

Image

Acceptance criteria

@kpatticha kpatticha added the Feature:EntitiesInventory Observability entities inventory feature label Sep 13, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 13, 2024
@kpatticha kpatticha added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team and removed needs-team Issues missing a team label Feature:EntitiesInventory Observability entities inventory feature labels Sep 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith added the enhancement New value added to drive a business result label Sep 13, 2024
@iblancof iblancof self-assigned this Sep 20, 2024
@iblancof
Copy link
Contributor

@kpatticha, I have a question about the removal of the link to enable the new experience ('Try our new experience!').

In the acceptance criteria, we state that the "Try our new Inventory!" link should only be displayed if apm.service.inventory.view is set to classic. However, the 'Try our new experience!' link is currently showing regardless of whether the view is classic or entity.

Should we remove it regardless of the inventory view? If not, when apm.service.inventory.view is set to entity, should we continue to display 'Try our new experience!'?

@kpatticha
Copy link
Contributor Author

@iblancof which AC are you referring to?

@kpatticha
Copy link
Contributor Author

kpatticha commented Sep 23, 2024

Regarding

when apm.service.inventory.view is set to entity, should we continue to display 'Try our new experience!'?

No, we should not. We'll remove the new service inventory and the user won't have any option to enable/disable this view.

In the acceptance I had added the following to ensure the view is always classic.

  • apm.service.inventory.view local storage should be 'classic'

@iblancof
Copy link
Contributor

Oh, I see. So what the AC is actually specifying is that whenever I enter the services inventory, I should set apm.service.inventory.view to classic by default. Am I right?

I initially understood it the other way around, that the new behavior (showing the new link and removing the old one) would only occur if the inventory view mode was set to 'classic', and no changes were necessary otherwise.

@kpatticha, could you please confirm if I got this right?

@kpatticha
Copy link
Contributor Author

Oh, I see. So what the AC is actually specifying is that whenever I enter the services inventory, I should set apm.service.inventory.view to classic by default. Am I right?

Yes! This is in case a user has already switched to the new view (entity), we need to ensure it always defaults to the classic view, as we're removing the option to switch back. Or you can simply remove the condition where we switch to the new multi signal table. Up to you

I initially understood it the other way around, that the new behavior (showing the new link and removing the old one) would only occur if the inventory view mode was set to 'classic', and no changes were necessary otherwise.

No, we will remove the "new Service" Inventory in apm. The link will basically point to the new inventory plugin

Let me know if you need further clarification.

iblancof added a commit that referenced this issue Sep 30, 2024
## Summary

Closes #192856.

This PR removes the ability to enable the new APM experience and
replaces it with a link promoting the new Inventory feature.

![Screen Recording 2024-09-25 at 15 02
29](https://github.com/user-attachments/assets/5dc6b8af-f207-43e5-8125-fffb4b823e4d)

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 30, 2024
## Summary

Closes elastic#192856.

This PR removes the ability to enable the new APM experience and
replaces it with a link promoting the new Inventory feature.

![Screen Recording 2024-09-25 at 15 02
29](https://github.com/user-attachments/assets/5dc6b8af-f207-43e5-8125-fffb4b823e4d)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9f9d911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants