-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Create observability-specific setting for excluding data tiers from queries #192570
[Observability] Create observability-specific setting for excluding data tiers from queries #192570
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
0e65086
to
2b4cd56
Compare
2b4cd56
to
cc7e886
Compare
/ci |
'xpack.observability.advancedSettings.searchExcludedDataTiersDesc', | ||
{ | ||
defaultMessage: `Specify the data tiers to exclude from search, such as data_cold and/or data_frozen. | ||
When configured, indices allocated in the selected tiers will be ignored from search requests.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add here which parts of o11y will be impacted
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obs-ux-management code changes LGTM
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test locally, but core changes LGTM.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
telemetry changes LGTM. added a new telemetry field observability:searchExcludedDataTiers
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…ata tiers from queries (elastic#192570) part of [elastic#190559](elastic#190559) ## Summary This PR introduces a new `Advanced Settings` under `Observabilty` to provide a way of configuring the exclusion of indices in the `data_cold` and/or `data_frozen` tiers from queries. The change will help to address issues encountered in O11y, most specifically in APM, and could also affect Infra and other features, with unbounded queries targeting the frozen tier. ### For reviewers This PR replaces elastic#192276 --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit f029f80)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ding data tiers from queries (#192570) (#193784) # Backport This will backport the following commits from `main` to `8.x`: - [[Observability] Create observability-specific setting for excluding data tiers from queries (#192570)](#192570) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T14:58:13Z","message":"[Observability] Create observability-specific setting for excluding data tiers from queries (#192570)\n\npart of [#190559](https://github.com/elastic/kibana/issues/190559)\r\n\r\n## Summary\r\n\r\nThis PR introduces a new `Advanced Settings` under `Observabilty` to\r\nprovide a way of configuring the exclusion of indices in the `data_cold`\r\nand/or `data_frozen` tiers from queries.\r\n\r\nThe change will help to address issues encountered in O11y, most\r\nspecifically in APM, and could also affect Infra and other features,\r\nwith unbounded queries targeting the frozen tier.\r\n\r\n### For reviewers\r\n\r\nThis PR replaces https://github.com/elastic/kibana/pull/192276\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f029f8086a6731b5f435775c915d46e110a34658","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"number":192570,"url":"https://github.com/elastic/kibana/pull/192570","mergeCommit":{"message":"[Observability] Create observability-specific setting for excluding data tiers from queries (#192570)\n\npart of [#190559](https://github.com/elastic/kibana/issues/190559)\r\n\r\n## Summary\r\n\r\nThis PR introduces a new `Advanced Settings` under `Observabilty` to\r\nprovide a way of configuring the exclusion of indices in the `data_cold`\r\nand/or `data_frozen` tiers from queries.\r\n\r\nThe change will help to address issues encountered in O11y, most\r\nspecifically in APM, and could also affect Infra and other features,\r\nwith unbounded queries targeting the frozen tier.\r\n\r\n### For reviewers\r\n\r\nThis PR replaces https://github.com/elastic/kibana/pull/192276\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f029f8086a6731b5f435775c915d46e110a34658"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192570","number":192570,"mergeCommit":{"message":"[Observability] Create observability-specific setting for excluding data tiers from queries (#192570)\n\npart of [#190559](https://github.com/elastic/kibana/issues/190559)\r\n\r\n## Summary\r\n\r\nThis PR introduces a new `Advanced Settings` under `Observabilty` to\r\nprovide a way of configuring the exclusion of indices in the `data_cold`\r\nand/or `data_frozen` tiers from queries.\r\n\r\nThe change will help to address issues encountered in O11y, most\r\nspecifically in APM, and could also affect Infra and other features,\r\nwith unbounded queries targeting the frozen tier.\r\n\r\n### For reviewers\r\n\r\nThis PR replaces https://github.com/elastic/kibana/pull/192276\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f029f8086a6731b5f435775c915d46e110a34658"}}]}] BACKPORT-->
part of #190559
Summary
This PR introduces a new
Advanced Settings
underObservabilty
to provide a way of configuring the exclusion of indices in thedata_cold
and/ordata_frozen
tiers from queries.The change will help to address issues encountered in O11y, most specifically in APM, and could also affect Infra and other features, with unbounded queries targeting the frozen tier.
For reviewers
This PR replaces #192276