Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip context awareness tests #192074

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[Discover] Unskip context awareness tests #192074

merged 4 commits into from
Sep 5, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 4, 2024 •
edited
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.16.0 labels Sep 4, 2024
@jughosta jughosta self-assigned this Sep 4, 2024
@jughosta
Copy link
Contributor Author

jughosta commented Sep 4, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6850

[❌] x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts: 44/50 tests passed.

see run history

@jughosta
Copy link
Contributor Author

jughosta commented Sep 4, 2024

/ci

@jughosta
Copy link
Contributor Author

jughosta commented Sep 4, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6852

[✅] x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/config.context_awareness.ts: 50/50 tests passed.
[❌] test/functional/apps/discover/context_awareness/config.ts: 22/50 tests passed.

see run history

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6855

[✅] test/functional/apps/discover/context_awareness/config.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/config.context_awareness.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/config.context_awareness.ts: 50/50 tests passed.

see run history

@jughosta jughosta marked this pull request as ready for review September 4, 2024 18:26
@jughosta jughosta requested a review from a team as a code owner September 4, 2024 18:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta enabled auto-merge (squash) September 4, 2024 18:27
davismcphee
davismcphee approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these 🙏

@jughosta jughosta merged commit 80f920d into elastic:main Sep 5, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 5, 2024
@jughosta jughosta deleted the 191260-unskip-context-tests branch September 5, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/context_awareness/extensions/_get_cell_renderers·ts - discover/context_awareness extension getCellRenderers data view mode should render log.level badge cell Failing test: Serverless Security Discover Context Awareness Functional Tests.x-pack/test_serverless/functional/test_suites/common/discover/context_awareness/extensions/_get_default_app_state·ts - discover/context_awareness extension getDefaultAppState data view mode should render default columns and row height Failing test: Serverless Observability Discover Context Awareness Functional Tests.x-pack/test_serverless/functional/test_suites/common/discover/context_awareness/extensions/_get_default_app_state·ts - discover/context_awareness extension getDefaultAppState data view mode should render default columns and row height Failing test: Serverless Security Discover Context Awareness Functional Tests.x-pack/test_serverless/functional/test_suites/common/discover/context_awareness/extensions/_get_default_app_state·ts - discover/context_awareness extension getDefaultAppState data view mode should merge and dedup configured default columns with default profile columns Failing test: Serverless Observability Discover Context Awareness Functional Tests.x-pack/test_serverless/functional/test_suites/common/discover/context_awareness/extensions/_get_default_app_state·ts - discover/context_awareness extension getDefaultAppState data view mode should merge and dedup configured default columns with default profile columns
Failing test: Chrome UI Functional Tests.test/functional/apps/discover/context_awareness/extensions/_get_cell_renderers·ts - discover/context_awareness extension getCellRenderers data view mode should not render log.level badge cell if it's not a logs data source
5 participants
@jughosta @kibanamachine @kibana-ci @elasticmachine @davismcphee