[Discover] Unskip context awareness tests (#192074)

- Closes #191260 - Closes #190725 - Closes #190629 - Closes #191921 - Closes #189994 - Closes #192095
elastic · Sep 5, 2024 · 80f920d · 80f920d
1 parent 4710b0d
commit 80f920d
Show file tree

Hide file tree

Showing 4 changed files with 150 additions and 58 deletions.
diff --git a/test/functional/apps/discover/context_awareness/extensions/_get_cell_renderers.ts b/test/functional/apps/discover/context_awareness/extensions/_get_cell_renderers.ts
@@ -8,6 +8,7 @@
 
 import kbnRison from '@kbn/rison';
 import expect from '@kbn/expect';
+import type { WebElementWrapper } from '@kbn/ftr-common-functional-ui-services';
 import type { FtrProviderContext } from '../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
@@ -18,6 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const dataViews = getService('dataViews');
   const queryBar = getService('queryBar');
   const browser = getService('browser');
+  const retry = getService('retry');
 
   describe('extension getCellRenderers', () => {
     before(async () => {
@@ -39,8 +41,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', `?_a=${state}`, {
           ensureCurrentUrl: false,
         });
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
         const firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 0);
         const logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
         expect(await logLevelBadge.getVisibleText()).to.be('debug');
@@ -59,11 +65,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', `?_a=${state}`, {
           ensureCurrentUrl: false,
         });
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
-        const firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 0);
-        expect(await firstCell.getVisibleText()).to.be('debug');
-        await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
+        await retry.try(async () => {
+          const firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 0);
+          expect(await firstCell.getVisibleText()).to.be('debug');
+          await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        });
       });
     });
 
@@ -72,17 +84,28 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-logs,logstash*');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-logs,logstash*');
         await queryBar.setQuery('log.level:*');
         await queryBar.submitQuery();
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
-        let firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
-        let logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
-        expect(await logLevelBadge.getVisibleText()).to.be('debug');
-        expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
-          'rgba(190, 207, 227, 1)'
-        );
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
+        let firstCell: WebElementWrapper;
+        let logLevelBadge: WebElementWrapper;
+
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
+          logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
+          expect(await logLevelBadge.getVisibleText()).to.be('debug');
+          expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
+            'rgba(190, 207, 227, 1)'
+          );
+        });
 
         // check Surrounding docs page
         await dataGrid.clickRowToggle();
@@ -92,26 +115,38 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await browser.refresh();
         await PageObjects.header.waitUntilLoadingHasFinished();
 
-        firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
-        logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
-        expect(await logLevelBadge.getVisibleText()).to.be('debug');
-        expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
-          'rgba(190, 207, 227, 1)'
-        );
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
+          logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
+          expect(await logLevelBadge.getVisibleText()).to.be('debug');
+          expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
+            'rgba(190, 207, 227, 1)'
+          );
+        });
       });
 
       it("should not render log.level badge cell if it's not a logs data source", async () => {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-*');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-*');
         await queryBar.setQuery('log.level:*');
         await queryBar.submitQuery();
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
-        let firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
-        expect(await firstCell.getVisibleText()).to.be('debug');
-        await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
+        let firstCell: WebElementWrapper;
+
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
+          expect(await firstCell.getVisibleText()).to.be('debug');
+          await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        });
 
         // check Surrounding docs page
         await dataGrid.clickRowToggle();
@@ -121,9 +156,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await browser.refresh();
         await PageObjects.header.waitUntilLoadingHasFinished();
 
-        firstCell = await dataGrid.getCellElementExcludingControlColumns(1, 1);
-        expect(await firstCell.getVisibleText()).to.be('debug');
-        await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(1, 1);
+          expect(await firstCell.getVisibleText()).to.be('debug');
+          await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        });
       });
     });
   });

diff --git a/test/functional/apps/discover/context_awareness/extensions/_get_default_app_state.ts b/test/functional/apps/discover/context_awareness/extensions/_get_default_app_state.ts
@@ -89,6 +89,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', `?_a=${state}`, {
           ensureCurrentUrl: false,
         });
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemRemove('log.level');
         await PageObjects.unifiedFieldList.clickFieldListItemRemove('message');
@@ -128,7 +129,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-logs');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-logs');
         await expectColumns(['@timestamp', 'log.level', 'message']);
         await dataGrid.clickGridSettings();
         const rowHeightValue = await dataGrid.getCurrentRowHeightValue();
@@ -141,14 +144,16 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-*');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-*');
         await expectColumns(['@timestamp', 'Document']);
         await dataGrid.clickGridSettings();
         let rowHeightValue = await dataGrid.getCurrentRowHeightValue();
         expect(rowHeightValue).to.be('Custom');
         let rowHeightNumber = await dataGrid.getCustomRowHeightNumber();
         expect(rowHeightNumber).to.be(3);
-        await dataViews.switchTo('my-example-logs');
+        await dataViews.switchToAndValidate('my-example-logs');
         await expectColumns(['@timestamp', 'log.level', 'message']);
         await dataGrid.clickGridSettings();
         rowHeightValue = await dataGrid.getCurrentRowHeightValue();
@@ -161,7 +166,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-logs');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-logs');
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemRemove('log.level');
         await PageObjects.unifiedFieldList.clickFieldListItemRemove('message');
@@ -186,7 +193,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-logs');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-logs');
         await expectColumns(['@timestamp', 'log.level', 'message', 'data_stream.type']);
       });
     });

diff --git a/...unctional/test_suites/common/discover/context_awareness/extensions/_get_cell_renderers.ts b/...unctional/test_suites/common/discover/context_awareness/extensions/_get_cell_renderers.ts
@@ -7,6 +7,7 @@
 
 import kbnRison from '@kbn/rison';
 import expect from '@kbn/expect';
+import type { WebElementWrapper } from '@kbn/ftr-common-functional-ui-services';
 import type { FtrProviderContext } from '../../../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
@@ -23,6 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const dataViews = getService('dataViews');
   const queryBar = getService('queryBar');
   const browser = getService('browser');
+  const retry = getService('retry');
 
   describe('extension getCellRenderers', () => {
     before(async () => {
@@ -45,8 +47,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', `?_a=${state}`, {
           ensureCurrentUrl: false,
         });
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
         const firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 0);
         const logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
         expect(await logLevelBadge.getVisibleText()).to.be('debug');
@@ -65,11 +71,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', `?_a=${state}`, {
           ensureCurrentUrl: false,
         });
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
-        const firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 0);
-        expect(await firstCell.getVisibleText()).to.be('debug');
-        await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
+        await retry.try(async () => {
+          const firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 0);
+          expect(await firstCell.getVisibleText()).to.be('debug');
+          await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        });
       });
     });
 
@@ -78,17 +90,28 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-logs,logstash*');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-logs,logstash*');
         await queryBar.setQuery('log.level:*');
         await queryBar.submitQuery();
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
-        let firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
-        let logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
-        expect(await logLevelBadge.getVisibleText()).to.be('debug');
-        expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
-          'rgba(190, 207, 227, 1)'
-        );
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
+        let firstCell: WebElementWrapper;
+        let logLevelBadge: WebElementWrapper;
+
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
+          logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
+          expect(await logLevelBadge.getVisibleText()).to.be('debug');
+          expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
+            'rgba(190, 207, 227, 1)'
+          );
+        });
 
         // check Surrounding docs page
         await dataGrid.clickRowToggle();
@@ -98,26 +121,38 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await browser.refresh();
         await PageObjects.header.waitUntilLoadingHasFinished();
 
-        firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
-        logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
-        expect(await logLevelBadge.getVisibleText()).to.be('debug');
-        expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
-          'rgba(190, 207, 227, 1)'
-        );
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
+          logLevelBadge = await firstCell.findByTestSubject('*logLevelBadgeCell-');
+          expect(await logLevelBadge.getVisibleText()).to.be('debug');
+          expect(await logLevelBadge.getComputedStyle('background-color')).to.be(
+            'rgba(190, 207, 227, 1)'
+          );
+        });
       });
 
       it("should not render log.level badge cell if it's not a logs data source", async () => {
         await PageObjects.common.navigateToActualUrl('discover', undefined, {
           ensureCurrentUrl: false,
         });
-        await dataViews.switchTo('my-example-*');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await dataViews.switchToAndValidate('my-example-*');
         await queryBar.setQuery('log.level:*');
         await queryBar.submitQuery();
+        await PageObjects.header.waitUntilLoadingHasFinished();
         await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.clickFieldListItemAdd('log.level');
-        let firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
-        expect(await firstCell.getVisibleText()).to.be('debug');
-        await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        await PageObjects.header.waitUntilLoadingHasFinished();
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+
+        let firstCell: WebElementWrapper;
+
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(0, 1);
+          expect(await firstCell.getVisibleText()).to.be('debug');
+          await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        });
 
         // check Surrounding docs page
         await dataGrid.clickRowToggle();
@@ -127,9 +162,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await browser.refresh();
         await PageObjects.header.waitUntilLoadingHasFinished();
 
-        firstCell = await dataGrid.getCellElementExcludingControlColumns(1, 1);
-        expect(await firstCell.getVisibleText()).to.be('debug');
-        await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        await retry.try(async () => {
+          firstCell = await dataGrid.getCellElementExcludingControlColumns(1, 1);
+          expect(await firstCell.getVisibleText()).to.be('debug');
+          await testSubjects.missingOrFail('*logLevelBadgeCell-');
+        });
       });
     });
   });