New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detection Engine] Update toast message for adding exception #191032

Merged

yctercero merged 4 commits into elastic:main from yctercero:exceptions_toast

Aug 26, 2024

Contributor

yctercero commented Aug 21, 2024 •

edited by kibanamachine

Loading

Summary

Addresses #156246

Updates exception toast message to accurately reflect when it's an endpoint exception.

Screenshot 2024-08-21 at 4 27 15 PM

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility


          update toast message for adding exception

99cce9c

yctercero added bug release_note:skip v8.16.0 v8.15.1 labels

yctercero self-assigned this

yctercero requested a review from a team as a code owner

August 21, 2024 21:46

yctercero requested a review from e40pud

August 21, 2024 21:46

yctercero marked this pull request as draft

August 21, 2024 22:06

yctercero and others added 2 commits

August 21, 2024 21:03


          update translations

d85d05b


          Merge branch 'main' into exceptions_toast

6e79d6b

Contributor Author

yctercero commented Aug 22, 2024

/ci

e40pud approved these changes

View reviewed changes

Contributor

e40pud left a comment

Thanks for the update!

yctercero marked this pull request as ready for review

August 22, 2024 15:55


          Merge branch 'main' into exceptions_toast

25a949b

yctercero enabled auto-merge (squash)

August 26, 2024 19:56

Collaborator

kibana-ci commented Aug 26, 2024

💚 Build Succeeded

Buildkite Build
Commit: 25a949b

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	18.0MB	18.0MB	+984.0B

History

💛 Build #229208 was flaky 6e79d6b
💚 Build #229027 succeeded 6e79d6b
💔 Build #229002 failed 99cce9c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yctercero merged commit cbc8f17 into elastic:main

39 checks passed

Contributor

kibanamachine commented Aug 26, 2024

💔 All backports failed

Status	Branch	Result
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191032

Questions ?

Please refer to the Backport tool documentation

kibanamachine mentioned this pull request

[UII] Fix client-side validation for agent policy timeout fields #191674

Merged

kibanamachine mentioned this pull request

[ES|QL] Disable field statistics panel in Dashboard if ES|QL is disabled #193587

Merged

10 tasks

kibanamachine added the backport missing label

Contributor

kibanamachine commented Sep 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

2 similar comments

Contributor

kibanamachine commented Oct 1, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 3, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

1 similar comment

Contributor

kibanamachine commented Oct 4, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

yctercero deleted the exceptions_toast branch

October 4, 2024 16:16

Contributor

kibanamachine commented Oct 7, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

1 similar comment

Contributor

kibanamachine commented Oct 8, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 9, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

yctercero removed the v8.15.1 label

Contributor

kibanamachine commented Oct 10, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

14 similar comments

Contributor

kibanamachine commented Oct 11, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 14, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 15, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 17, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 18, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 22, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 23, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 24, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 25, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 28, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 29, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

Contributor

kibanamachine commented Oct 31, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 191032 locally

yctercero added the backport:skip label

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip bug release_note:skip v8.16.0