[ES|QL] Improve arithmetic unary expression nodes #189258
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:ES|QL
ES|QL related features in Kibana
Team:ESQL
ES|QL related features in Kibana
Comments
vadimkibana
added
Feature:ES|QL
|
Pinging @elastic/kibana-esql (Team:ESQL) |
8 tasks
vadimkibana
added
the
bug
This was referenced Oct 22, 2024
vadimkibana
added a commit
that referenced
this issue
Oct 22, 2024
## Summary Partially addresses #189258 This change will likely supercede #196817 When parsing, currently ES|QL parsers adds extraneous multiply by 1 or multiply by -1 nodes when parsing arithmetic unary expressions. For example, `-(x)` is parsed as `-1 * x`. This change, reverts these when pretty-printing using the `BasicPrettyPrinter`: `-1 * x` is pretty printed as `-x`. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 22, 2024
…#197182) ## Summary Partially addresses elastic#189258 This change will likely supercede elastic#196817 When parsing, currently ES|QL parsers adds extraneous multiply by 1 or multiply by -1 nodes when parsing arithmetic unary expressions. For example, `-(x)` is parsed as `-1 * x`. This change, reverts these when pretty-printing using the `BasicPrettyPrinter`: `-1 * x` is pretty printed as `-x`. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 848c9f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For unary arithmetic expressions, say
-column, the constructed AST is modified to create a binary expression wherecolumnis multiplied by-1. So,-columnis transformed to-1 * column. Instead we should just create a unary expressionfunctioncall node. We are already doing that forNOTunary expressions, likeNOT column.The text was updated successfully, but these errors were encountered: