[Entity Analytics] Flaky Cypress test fixes #186081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
changed the title
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6317[✅] Security Solution Entity Analytics - Cypress: 200/200 tests passed. |
|
@elasticmachine merge upstream |
hop-dev
commented
Jun 17, 2024
...lution_cypress/cypress/e2e/entity_analytics/dashboards/entity_analytics/new_risk_score.cy.ts
Show resolved
Hide resolved
hop-dev
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
tiansivive
approved these changes
Jun 18, 2024
kibanamachine
added
v8.15.0
backport:skip
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 18, 2024
### Fix 1: Press refresh button after using date picker on dashboard Closes elastic#183662 Closes elastic#183635 Closes elastic#183982 We shouldnt have to do this, but there is some condition where clicking apply gets the UI in a stuck state and I cant figure it out. ### Fix 2: Use more specific selector for search bar on risk score preview page Closes elastic#184133 We were using a generic selector `[data-test-subj="unifiedQueryInput"] textarea` which was bringing back two elements sometimes (no idea why), I have given the box its own dedicated selector to hopefully prevent this from happening --------- Co-authored-by: Kibana Machine <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
hop-dev
added a commit
to hop-dev/kibana
that referenced
this pull request
Jul 3, 2024
### Fix 1: Press refresh button after using date picker on dashboard Closes elastic#183662 Closes elastic#183635 Closes elastic#183982 We shouldnt have to do this, but there is some condition where clicking apply gets the UI in a stuck state and I cant figure it out. ### Fix 2: Use more specific selector for search bar on risk score preview page Closes elastic#184133 We were using a generic selector `[data-test-subj="unifiedQueryInput"] textarea` which was bringing back two elements sometimes (no idea why), I have given the box its own dedicated selector to hopefully prevent this from happening --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c34bb46)
hop-dev
added a commit
that referenced
this pull request
Jul 4, 2024
# Backport closes #187472 This will backport the following commits from `main` to `8.14`: - [[Entity Analytics] Flaky Cypress test fixes (#186081)](#186081) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-18T13:27:26Z","message":"[Entity Analytics] Flaky Cypress test fixes (#186081)\n\n### Fix 1: Press refresh button after using date picker on dashboard\r\n\r\nCloses https://github.com/elastic/kibana/issues/183662\r\nCloses https://github.com/elastic/kibana/issues/183635\r\nCloses https://github.com/elastic/kibana/issues/183982\r\n\r\nWe shouldnt have to do this, but there is some condition where clicking\r\napply gets the UI in a stuck state and I cant figure it out.\r\n\r\n### Fix 2: Use more specific selector for search bar on risk score\r\npreview page\r\n\r\nCloses https://github.com/elastic/kibana/issues/184133\r\n\r\nWe were using a generic selector `[data-test-subj=\"unifiedQueryInput\"]\r\ntextarea` which was bringing back two elements sometimes (no idea why),\r\nI have given the box its own dedicated selector to hopefully prevent\r\nthis from happening\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"c34bb46c8aeb59dca0c92132dd34d2d9fca68728","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Entity Analytics","v8.15.0"],"number":186081,"url":"https://github.com/elastic/kibana/pull/186081","mergeCommit":{"message":"[Entity Analytics] Flaky Cypress test fixes (#186081)\n\n### Fix 1: Press refresh button after using date picker on dashboard\r\n\r\nCloses https://github.com/elastic/kibana/issues/183662\r\nCloses https://github.com/elastic/kibana/issues/183635\r\nCloses https://github.com/elastic/kibana/issues/183982\r\n\r\nWe shouldnt have to do this, but there is some condition where clicking\r\napply gets the UI in a stuck state and I cant figure it out.\r\n\r\n### Fix 2: Use more specific selector for search bar on risk score\r\npreview page\r\n\r\nCloses https://github.com/elastic/kibana/issues/184133\r\n\r\nWe were using a generic selector `[data-test-subj=\"unifiedQueryInput\"]\r\ntextarea` which was bringing back two elements sometimes (no idea why),\r\nI have given the box its own dedicated selector to hopefully prevent\r\nthis from happening\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"c34bb46c8aeb59dca0c92132dd34d2d9fca68728"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186081","number":186081,"mergeCommit":{"message":"[Entity Analytics] Flaky Cypress test fixes (#186081)\n\n### Fix 1: Press refresh button after using date picker on dashboard\r\n\r\nCloses https://github.com/elastic/kibana/issues/183662\r\nCloses https://github.com/elastic/kibana/issues/183635\r\nCloses https://github.com/elastic/kibana/issues/183982\r\n\r\nWe shouldnt have to do this, but there is some condition where clicking\r\napply gets the UI in a stuck state and I cant figure it out.\r\n\r\n### Fix 2: Use more specific selector for search bar on risk score\r\npreview page\r\n\r\nCloses https://github.com/elastic/kibana/issues/184133\r\n\r\nWe were using a generic selector `[data-test-subj=\"unifiedQueryInput\"]\r\ntextarea` which was bringing back two elements sometimes (no idea why),\r\nI have given the box its own dedicated selector to hopefully prevent\r\nthis from happening\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"c34bb46c8aeb59dca0c92132dd34d2d9fca68728"}}]}] BACKPORT--> Co-authored-by: Elastic Machine <[email protected]>
|
This PR didn't make it on time to be included in the latest BC for v8.14.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1: Press refresh button after using date picker on dashboard
Closes #183662
Closes #183635
Closes #183982
We shouldnt have to do this, but there is some condition where clicking apply gets the UI in a stuck state and I cant figure it out.
Fix 2: Use more specific selector for search bar on risk score preview page
Closes #184133
We were using a generic selector
[data-test-subj="unifiedQueryInput"] textareawhich was bringing back two elements sometimes (no idea why), I have given the box its own dedicated selector to hopefully prevent this from happening