Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab #173156

Closed
mykolaharmash opened this issue Dec 12, 2023 · 5 comments · Fixed by #174242
Closed

[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab #173156

mykolaharmash opened this issue Dec 12, 2023 · 5 comments · Fixed by #174242
Assignees
@jennypavlova
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@mykolaharmash
Copy link
Contributor

mykolaharmash commented Dec 12, 2023 •
edited
Loading

"Universal Profiling" tab in host details should have a NEW badge.

Image
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 12, 2023
@mykolaharmash mykolaharmash added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 12, 2023
@jennypavlova jennypavlova self-assigned this Jan 3, 2024
@jennypavlova
Copy link
Member

@mykolaharmash Do we have any design requirements? I am asking because I saw that we already have a green NEW badge inside the profiling prompt and a pink NEW badge in the main nav menu (Synthetics) after the title:

Image

So do we want to have a pink badge like in the nav menu or a green or like in the prompt so:

Image

Or

Image

I am trying to have it consistent with the other elements so I am also not sure if we should have the prompt badge pink as well so all new labels are the same color. Wdyt?

cc: @kkurstak as this is maybe a design question.

@cauemarcondes
Copy link
Contributor

APM UI uses the pink one.

@jennypavlova
Copy link
Member

@cauemarcondes Yes, true. Do you think we should make all the badges pink (including the prompt badge so they are all the same?

@mykolaharmash
Copy link
Contributor Author

There is no design for this, but you're right, it should be consistent with other places, let's make all badges pink. Thank you for catching this!

@jennypavlova jennypavlova mentioned this issue Jan 4, 2024
Merged
jennypavlova added a commit that referenced this issue Jan 4, 2024
@jennypavlova
[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (#174242)
1182ce6 
Closes #173156 

## Summary

This PR adds a `NEW` badge to the profiling tab and changes the
profiling prompt badge color to pink

## Testing
The badges can be checked on the node details page and inside the host
details flyout:

![image](https://github.com/elastic/kibana/assets/14139027/30f4ca24-b460-4fe9-8c2c-372e435a1c64)

![image](https://github.com/elastic/kibana/assets/14139027/423232b2-fc2e-4718-a089-180157db22da)
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this issue Jan 16, 2024
@jennypavlova
[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (elastic…
1677f63 
…#174242)

Closes elastic#173156

## Summary

This PR adds a `NEW` badge to the profiling tab and changes the
profiling prompt badge color to pink

## Testing
The badges can be checked on the node details page and inside the host
details flyout:

![image](https://github.com/elastic/kibana/assets/14139027/30f4ca24-b460-4fe9-8c2c-372e435a1c64)

![image](https://github.com/elastic/kibana/assets/14139027/423232b2-fc2e-4718-a089-180157db22da)

(cherry picked from commit 1182ce6)
mykolaharmash added a commit that referenced this issue Jan 16, 2024
@mykolaharmash @jennypavlova
[8.12] [ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (#…
ceb379d 
…174242) (#174880)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab
(#174242)](#174242)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-04T16:09:09Z","message":"[ObsUX][Profiling,
Infra] Add NEW badge to the Profiling tab (#174242)\n\nCloses #173156
\r\n\r\n## Summary\r\n\r\nThis PR adds a `NEW` badge to the profiling
tab and changes the\r\nprofiling prompt badge color to pink\r\n\r\n##
Testing\r\nThe badges can be checked on the node details page and inside
the host\r\ndetails
flyout:\r\n\r\n![image](https://github.com/elastic/kibana/assets/14139027/30f4ca24-b460-4fe9-8c2c-372e435a1c64)\r\n\r\n![image](https://github.com/elastic/kibana/assets/14139027/423232b2-fc2e-4718-a089-180157db22da)","sha":"1182ce678c3b190aa5172f2b473db0d84ba12f5d","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-infra_services","v8.13.0"],"number":174242,"url":"https://github.com/elastic/kibana/pull/174242","mergeCommit":{"message":"[ObsUX][Profiling,
Infra] Add NEW badge to the Profiling tab (#174242)\n\nCloses #173156
\r\n\r\n## Summary\r\n\r\nThis PR adds a `NEW` badge to the profiling
tab and changes the\r\nprofiling prompt badge color to pink\r\n\r\n##
Testing\r\nThe badges can be checked on the node details page and inside
the host\r\ndetails
flyout:\r\n\r\n![image](https://github.com/elastic/kibana/assets/14139027/30f4ca24-b460-4fe9-8c2c-372e435a1c64)\r\n\r\n![image](https://github.com/elastic/kibana/assets/14139027/423232b2-fc2e-4718-a089-180157db22da)","sha":"1182ce678c3b190aa5172f2b473db0d84ba12f5d"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174242","number":174242,"mergeCommit":{"message":"[ObsUX][Profiling,
Infra] Add NEW badge to the Profiling tab (#174242)\n\nCloses #173156
\r\n\r\n## Summary\r\n\r\nThis PR adds a `NEW` badge to the profiling
tab and changes the\r\nprofiling prompt badge color to pink\r\n\r\n##
Testing\r\nThe badges can be checked on the node details page and inside
the host\r\ndetails
flyout:\r\n\r\n![image](https://github.com/elastic/kibana/assets/14139027/30f4ca24-b460-4fe9-8c2c-372e435a1c64)\r\n\r\n![image](https://github.com/elastic/kibana/assets/14139027/423232b2-fc2e-4718-a089-180157db22da)","sha":"1182ce678c3b190aa5172f2b473db0d84ba12f5d"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab jennypavlova/kibana
4 participants
@mykolaharmash @jennypavlova @elasticmachine @cauemarcondes