Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom Threshold] Add rate and percentile aggs to the rule #172945

Closed
4 tasks done
paulb-elastic opened this issue Dec 8, 2023 · 3 comments · Fixed by #173728
Closed
4 tasks done

[Custom Threshold] Add rate and percentile aggs to the rule #172945

paulb-elastic opened this issue Dec 8, 2023 · 3 comments · Fixed by #173728
Labels
Feature:Alerting Feature: Custom threshold Observability custom threshold rule type Team:obs-ux-management Observability Management User Experience Team v8.13.0

Comments

@paulb-elastic
Copy link
Contributor

paulb-elastic commented Dec 8, 2023 •
edited by fkanout
Loading

image

ACs

  • Add the following additional aggregations to the Custom Threshold rule
    • Rate aggs
    • Percentile aggs
  • Update the parser to match the new aggs with Lens
@paulb-elastic paulb-elastic added the Team:obs-ux-management Observability Management User Experience Team label Dec 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@fkanout fkanout mentioned this issue Dec 9, 2023
Merged
@fkanout
Copy link
Contributor

fkanout commented Dec 9, 2023

I believe this issue should be done before the prefill functionality #170295 as I explained here #172783 (review)

@maryam-saeidi
Copy link
Member

I don't think this ticket is a blocker for the prefill functionality, I added a comment here.

@fkanout fkanout self-assigned this Dec 13, 2023
@fkanout fkanout added Feature:Alerting Feature: Custom threshold Observability custom threshold rule type labels Dec 13, 2023
@fkanout fkanout mentioned this issue Dec 20, 2023
Merged
@fkanout fkanout added the v8.13.0 label Jan 2, 2024
fkanout added a commit that referenced this issue Feb 7, 2024
@fkanout
[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold …
ed2e3f8 
…rule (#173728)

## Summary

Fixes #172945 by adding P95, P99, and RATE Aggs to the Custom Threshold
rule

<img width="575" alt="Screenshot 2023-12-20 at 12 31 50"
src="https://github.com/elastic/kibana/assets/6838659/fd9f33fc-97c5-4cf8-b15e-3134048c861a">
<img width="565" alt="Screenshot 2023-12-20 at 12 31 57"
src="https://github.com/elastic/kibana/assets/6838659/56047c84-a6e5-4a8a-a05f-b6c1358a7297">
<img width="601" alt="Screenshot 2023-12-20 at 12 36 16"
src="https://github.com/elastic/kibana/assets/6838659/af7c291d-320f-4cb1-b62f-46e29f596bcd">
fkanout added a commit to fkanout/kibana that referenced this issue Feb 7, 2024
@fkanout
[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold …
7bf5164 
…rule (elastic#173728)

## Summary

Fixes elastic#172945 by adding P95, P99, and RATE Aggs to the Custom Threshold
rule

<img width="575" alt="Screenshot 2023-12-20 at 12 31 50"
src="https://github.com/elastic/kibana/assets/6838659/fd9f33fc-97c5-4cf8-b15e-3134048c861a">
<img width="565" alt="Screenshot 2023-12-20 at 12 31 57"
src="https://github.com/elastic/kibana/assets/6838659/56047c84-a6e5-4a8a-a05f-b6c1358a7297">
<img width="601" alt="Screenshot 2023-12-20 at 12 36 16"
src="https://github.com/elastic/kibana/assets/6838659/af7c291d-320f-4cb1-b62f-46e29f596bcd">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@fkanout @CoenWarmer
[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold …
dc82ef0 
…rule (elastic#173728)

## Summary

Fixes elastic#172945 by adding P95, P99, and RATE Aggs to the Custom Threshold
rule

<img width="575" alt="Screenshot 2023-12-20 at 12 31 50"
src="https://github.com/elastic/kibana/assets/6838659/fd9f33fc-97c5-4cf8-b15e-3134048c861a">
<img width="565" alt="Screenshot 2023-12-20 at 12 31 57"
src="https://github.com/elastic/kibana/assets/6838659/56047c84-a6e5-4a8a-a05f-b6c1358a7297">
<img width="601" alt="Screenshot 2023-12-20 at 12 36 16"
src="https://github.com/elastic/kibana/assets/6838659/af7c291d-320f-4cb1-b62f-46e29f596bcd">
fkanout added a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@fkanout
[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold …
93503ff 
…rule (elastic#173728)

## Summary

Fixes elastic#172945 by adding P95, P99, and RATE Aggs to the Custom Threshold
rule

<img width="575" alt="Screenshot 2023-12-20 at 12 31 50"
src="https://github.com/elastic/kibana/assets/6838659/fd9f33fc-97c5-4cf8-b15e-3134048c861a">
<img width="565" alt="Screenshot 2023-12-20 at 12 31 57"
src="https://github.com/elastic/kibana/assets/6838659/56047c84-a6e5-4a8a-a05f-b6c1358a7297">
<img width="601" alt="Screenshot 2023-12-20 at 12 36 16"
src="https://github.com/elastic/kibana/assets/6838659/af7c291d-320f-4cb1-b62f-46e29f596bcd">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Alerting Feature: Custom threshold Observability custom threshold rule type Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold rule fkanout/kibana
4 participants
@fkanout @maryam-saeidi @elasticmachine @paulb-elastic