Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests with ES SSL - Triggers Actions UI.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Rule Details Edit rule button should open edit rule flyout #172941

Closed
kibanamachine opened this issue Dec 8, 2023 · 6 comments · Fixed by #183888
Closed

Failing test: Chrome X-Pack UI Functional Tests with ES SSL - Triggers Actions UI.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Rule Details Edit rule button should open edit rule flyout #172941

kibanamachine opened this issue Dec 8, 2023 · 6 comments · Fixed by #183888
Assignees
@umbopepato
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 8, 2023 •
edited
Loading

A test failed on a tracked branch

Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="ruleNameInput"])
Wait timed out after 10015ms
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-c6dcfff75613e58f/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at Proxy.clickByCssSelector (find.ts:417:5)
    at TestSubjects.click (test_subjects.ts:164:5)
    at test_subjects.ts:271:7
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.try (retry.ts:31:12)
    at TestSubjects.setValue (test_subjects.ts:268:12)
    at Context.<anonymous> (details.ts:374:9)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at TestSubjects.setValue (test_subjects.ts:268:12)
    at Context.<anonymous> (details.ts:374:9)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Dec 8, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 8, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Dec 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 8, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Dec 12, 2023
@mistic
skip flaky suite (#172941)
a1e0236
@mistic
Copy link
Member

mistic commented Dec 12, 2023

Skipped.

main: a1e0236

@umbopepato umbopepato self-assigned this May 13, 2024
@cnasikas cnasikas added v8.15.0 and removed v8.13.0 labels May 15, 2024
@umbopepato umbopepato mentioned this issue May 21, 2024
Merged
umbopepato added a commit that referenced this issue May 24, 2024
@umbopepato
[ResponseOps][Rules] Fix flaky rule details page tests (#183888)
e7e0c86 
## Summary

Prevents the rule details page's lazyly loaded components from
re-triggering the fallback state of the top-level `<Suspense>` that was
causing a _Flash of Content_, the likely cause of #172941 and #173008.

## Details

<details>
<summary>
Slowed down screen capture of the loading flash
</summary>


https://github.com/elastic/kibana/assets/18363145/8ab0bd7c-bcef-417f-9930-ef03aeec6e8b
</details>

My guess is that in the flaky test runs the `Edit` button was pressed
just before the component was temporarily removed from the render tree
and therefore the flyout couldn't render correctly.

## To verify

1. Create any type of rule from `Stack Management`
2. Navigate to that rule's detail page (`Stack Management` > `Rules` >
Click on rule in list)
3. Verify that the page header only loads once without going back to the
loading indicator (throttling the network from the DevTools or capturing
the screen and playing back the video slowed down might help).

Fixes #172941
Fixes #173008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umbopepato umbopepato

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Rules] Fix flaky rule details page tests umbopepato/kibana
5 participants
@mistic @cnasikas @elasticmachine @umbopepato @kibanamachine