[RAM] Fix rule edit flyout alerts search bar autocomplete scroll #172899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
XavierM
requested review from
Zacqary and
umbopepato
and removed request for
Zacqary
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
umbopepato
reviewed
Dec 20, 2023
| @@ -213,7 +213,7 @@ export const RuleEdit = ({ | |||
| aria-labelledby="flyoutRuleEditTitle" | |||
| size="m" | |||
| maxWidth={620} | |||
| ownFocus={false} | |||
There was a problem hiding this comment.
I'm wondering why ownFocus={false} was added in the first place 🤔
Being able to interact with the rest of the page outside of the flyout doesn't seem too useful in this case...
There was a problem hiding this comment.
Yea I had the same thought. Did a git blame and turns out it was added 3 years ago.
umbopepato
approved these changes
Dec 20, 2023
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 20, 2023
…stic#172899) ## Summary Resolves: elastic#172594 Fixes the rule edit alerts search bar autocomplete causing background to also scroll infinitely https://github.com/elastic/kibana/assets/74562234/f55db528-b933-400a-80b5-8a3063f0f29c --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> (cherry picked from commit 4465c1e)
kibanamachine
added a commit
that referenced
this pull request
Dec 20, 2023
…ll (#172899) (#173789) # Backport This will backport the following commits from `main` to `8.12`: - [[RAM] Fix rule edit flyout alerts search bar autocomplete scroll (#172899)](#172899) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-20T20:21:51Z","message":"[RAM] Fix rule edit flyout alerts search bar autocomplete scroll (#172899)\n\n## Summary\r\nResolves: https://github.com/elastic/kibana/issues/172594\r\n\r\nFixes the rule edit alerts search bar autocomplete causing background to\r\nalso scroll infinitely\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/74562234/f55db528-b933-400a-80b5-8a3063f0f29c\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Xavier Mouligneau <[email protected]>","sha":"4465c1e090ab1179f12000d52b1dc0eefd14217f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.11.0","v8.12.0","v8.13.0"],"number":172899,"url":"https://github.com/elastic/kibana/pull/172899","mergeCommit":{"message":"[RAM] Fix rule edit flyout alerts search bar autocomplete scroll (#172899)\n\n## Summary\r\nResolves: https://github.com/elastic/kibana/issues/172594\r\n\r\nFixes the rule edit alerts search bar autocomplete causing background to\r\nalso scroll infinitely\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/74562234/f55db528-b933-400a-80b5-8a3063f0f29c\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Xavier Mouligneau <[email protected]>","sha":"4465c1e090ab1179f12000d52b1dc0eefd14217f"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.12"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172899","number":172899,"mergeCommit":{"message":"[RAM] Fix rule edit flyout alerts search bar autocomplete scroll (#172899)\n\n## Summary\r\nResolves: https://github.com/elastic/kibana/issues/172594\r\n\r\nFixes the rule edit alerts search bar autocomplete causing background to\r\nalso scroll infinitely\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/74562234/f55db528-b933-400a-80b5-8a3063f0f29c\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Xavier Mouligneau <[email protected]>","sha":"4465c1e090ab1179f12000d52b1dc0eefd14217f"}}]}] BACKPORT--> Co-authored-by: Jiawei Wu <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
JiaweiWu
added a commit
to JiaweiWu/kibana
that referenced
this pull request
Dec 20, 2023
…stic#172899) ## Summary Resolves: elastic#172594 Fixes the rule edit alerts search bar autocomplete causing background to also scroll infinitely https://github.com/elastic/kibana/assets/74562234/f55db528-b933-400a-80b5-8a3063f0f29c --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> (cherry picked from commit 4465c1e) # Conflicts: # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #172594
Fixes the rule edit alerts search bar autocomplete causing background to also scroll infinitely
2023-12-07.15-21-10.mp4