Skip to content

Commit

Permalink
[RAM] Fix rule edit flyout alerts search bar autocomplete scroll (#17…
Browse files Browse the repository at this point in the history
…2899)

## Summary
Resolves: #172594

Fixes the rule edit alerts search bar autocomplete causing background to
also scroll infinitely



https://github.com/elastic/kibana/assets/74562234/f55db528-b933-400a-80b5-8a3063f0f29c

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Xavier Mouligneau <[email protected]>
  • Loading branch information
3 people authored Dec 20, 2023
1 parent 35d79a9 commit 4465c1e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export const RuleEdit = ({
aria-labelledby="flyoutRuleEditTitle"
size="m"
maxWidth={620}
ownFocus={false}
ownFocus
>
<EuiFlyoutHeader hasBorder>
<EuiTitle size="s" data-test-subj="editRuleFlyoutTitle">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
}

describe('create alert', function () {
before(async () => {
beforeEach(async () => {
await pageObjects.common.navigateToApp('triggersActions');
await testSubjects.click('rulesTab');
});

afterEach(async () => {
// Reset the Rules tab without reloading the entire page
// This is safer than trying to close the alert flyout, which may or may not be open at the end of a test
await testSubjects.click('logsTab');
await testSubjects.click('rulesTab');
});

it('should delete the right action when the same action has been added twice', async () => {
// create a new rule
const ruleName = generateUniqueKey();
Expand Down

0 comments on commit 4465c1e

Please sign in to comment.