Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Filter Overflow When To Much Filters Active #172855

Closed
jcger opened this issue Dec 7, 2023 · 2 comments · Fixed by #172860
Closed

[Cases] Filter Overflow When To Much Filters Active #172855

jcger opened this issue Dec 7, 2023 · 2 comments · Fixed by #172860
Assignees
@jcger
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0

Comments

@jcger
Copy link
Contributor

jcger commented Dec 7, 2023 •
edited
Loading

There is an issue when the user does activate to many filters. It overflows hiding the More button

Tasks:

  • Every filter should be separated like in the initial design. To achieve that we will have to wrap every single filter in a FilterGroup so that the styling is applied.
  • The More button needs to have a white background to differentiate it from the rest
  • We need to truncate the button labels
@jcger jcger added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.12.0 labels Dec 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

This was referenced Dec 7, 2023
Merged
Merged
@jcger jcger self-assigned this Dec 11, 2023
jcger added a commit that referenced this issue Dec 11, 2023
@jcger
[Cases] Filter Overflow When To Much Filters Active (#172860)
f7b0e49 
Closes #172855


![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 11, 2023
@jcger
[Cases] Filter Overflow When To Much Filters Active (elastic#172860)
32e6fcc 
Closes elastic#172855

![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)

(cherry picked from commit f7b0e49)
kibanamachine referenced this issue Dec 11, 2023
@kibanamachine @jcger
[8.12] [Cases] Filter Overflow When To Much Filters Active (#172860) (#…
6333a72 
…173045)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Cases] Filter Overflow When To Much Filters Active
(#172860)](#172860)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T12:33:34Z","message":"[Cases]
Filter Overflow When To Much Filters Active (#172860)\n\nCloses
https://github.com/elastic/kibana/issues/172855\r\n\r\n\r\n![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)","sha":"f7b0e49e2f81cf4e995f6877731281db01566909","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.12.0","v8.13.0"],"number":172860,"url":"https://github.com/elastic/kibana/pull/172860","mergeCommit":{"message":"[Cases]
Filter Overflow When To Much Filters Active (#172860)\n\nCloses
https://github.com/elastic/kibana/issues/172855\r\n\r\n\r\n![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)","sha":"f7b0e49e2f81cf4e995f6877731281db01566909"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172860","number":172860,"mergeCommit":{"message":"[Cases]
Filter Overflow When To Much Filters Active (#172860)\n\nCloses
https://github.com/elastic/kibana/issues/172855\r\n\r\n\r\n![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)","sha":"f7b0e49e2f81cf4e995f6877731281db01566909"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcger jcger

Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Filter Overflow When To Much Filters Active jcger/kibana
2 participants
@elasticmachine @jcger