Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs Assistant] Inline editing of Lens embeddable #171934

Closed
wants to merge 3 commits into from

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 24, 2023

Summary

Super dirty - DO NOT MERGE

This is a PoC of editing the Lens visualizations from the assistant. It opens a push flyout and the user can edit the embeddable without navigating to Lens. It is dirty and buggy. The api will be improved in the next minors. I just want to gather use cases to see which is the best implementation.

The intention of this PoC is to see if we want a behavior like this in the obs assistant.

Advantages

  • User doesn't go away from the assistant
  • Changes in the panel are visible in the assistant embeddable
  • I can save the changes I made immediately from the assistant (doesnt work in this PoC)

Disadvantages (?)

  • Does it make sense to give so many capabilities to the user in the obs assistant? Possibly yes, would love some feedback here

obs_assistant

DON'T (not functional at this PR)

  • Add reference line
  • Add new layer

@stratoula
Copy link
Contributor Author

stratoula commented Nov 24, 2023

cc @dgieselaar wdyt?

I am not sure if we can store somehow the configuration that the user did on the flyout and next time the user visits again this conversation we show this instead of the default chart that we generated.

@stratoula stratoula changed the title [Obs Assistant] Edit in page [Obs Assistant] Inline editing of Lens embeddable Nov 24, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Investigations - Security Solution Cypress Tests #2 / Correlation tab should update timeline after removing eql should update timeline after removing eql

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 209.3KB 210.5KB +1.3KB
unifiedHistogram 50.6KB 50.6KB +12.0B
total +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 37.4KB 37.5KB +86.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar
Copy link
Member

@stratoula I think this is super nice especially if they can save the updated visualisation in the context of the conversation. As it stands that would mean that we'd have to convert it back to the adapter we're using. But there are other ways to deal with this.

@stratoula
Copy link
Contributor Author

@dgieselaar cool. we will figure it out I am sure.

Next steps:

  • I am going to work on 8.13 on improving the api. We should have all this configuration in Lens and not in the consumer
  • Create a new PR using the new api and figure out how to save the config in the conversation. I will need your help Dario on this.

cc @boriskirov. Not sure how you feel about it but would love your thoughts. Inline editing Lens embeddables is something we want to use across solutions (when it makes sense of course) as the user stays in the app and doesn't lose context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants