Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Improve the embeddable api to offer the inline editing with an easier way #167632

Closed
stratoula opened this issue Sep 29, 2023 · 2 comments · Fixed by #173841
Closed

[Lens] Improve the embeddable api to offer the inline editing with an easier way #167632

stratoula opened this issue Sep 29, 2023 · 2 comments · Fixed by #173841
Assignees
@stratoula
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Sep 29, 2023 •
edited
Loading

Describe the feature:
Lens now allows the inline editing of its embeddables and has already been adopted by dashboard, canvas and Discover.

image

This comes with great advantages:

  • the user doesn't change context from the current application
  • is more performant as the app doesnt need to reloaded when the user edits the chart in the editor and returns to the parent application

Right now the inline editing experience can be adopted by the Lens consumers with the same way Discover does.

We could make this even easier for the consumer. It can be a group of properties in the embeddable which would enable the inline editing easily without the need of importing the config panel from the Lens plugin.

Documentation on our developers examples is also required.
@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Sep 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula self-assigned this Nov 24, 2023
@stratoula
Copy link
Contributor Author

Except from Discover (already in main) here is another poc on the abs ai #171934. Right now a lot of things need to be set to the consumer. We need to move the logic to Lens (I think ui actions is the best path forward here). The consumer should only trigger the action (as we do in Visualize field)

@stratoula stratoula mentioned this issue Jan 3, 2024
Merged
stratoula added a commit that referenced this issue Jan 5, 2024
@stratoula @kibanamachine
[Lens][Inline editing] Improve the api for the embeddable consumers (#…
b37634d 
…173841)

## Summary

Closes #167632

This PR provides a simpler api for the Lens embeddable consumers who
want to provide inline editing capabilities. I added an example to help
with the integration. Run kibana with
```
yarn start --run-examples
```
http://localhost:5601/app/lens_embeddable_inline_editing_example

<img width="1381" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/58e7ef2d-2f92-4bab-9cb4-d04a90d87e15">

<img width="2498" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/0a050e8d-f22f-4c48-88e4-20c42683a279">

It also allows the consumers to render the inline editing component in a
custom element in case you don't want to open a push flyout.

![custom-container](https://github.com/elastic/kibana/assets/17003240/6ce1b9c6-dab0-4321-b4c0-ae196dfb4a84)


I included a readme on how to use the api.

### Note
This is the first PR which uses the new Lens config builder so some of
the changes are not related to the api improvements but they are fixing
some bugs on the builder.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens][Inline editing] Improve the api for the embeddable consumers stratoula/kibana
2 participants
@elasticmachine @stratoula