Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a namespace prefix for managed tags #171124

Closed
kpollich opened this issue Nov 13, 2023 · 5 comments
Closed

Generate a namespace prefix for managed tags #171124

kpollich opened this issue Nov 13, 2023 · 5 comments
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@kpollich
Copy link
Member

With the introduction #165655, duplicate tag names are prevented by Kibana. This means Fleet technically has an edge case where if a user creates a Managed tag or a tag with a name that matches an integration's title property before installing an integration, Fleet will fail to create the tag due to the collision.

One way we could fix this is by prefixing our "fleet sourced" flags with something like Elastic: to guarantee (or at least more convincingly guarantee) that we won't see collisions related to our tags.

cc @drewdaemon

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@drewdaemon
Copy link
Contributor

Supporting work on Kibana tagging (for example, preventing users from creating tags with the chosen prefix) can be requested from @elastic/appex-sharedux if it makes sense.

@sebelga
Copy link
Contributor

sebelga commented Nov 14, 2023

I like the suggestion that those managed resources (and the Elastic:) prefix are own by either core or SharedUX team. Making sure those are created at bootstrap time internally.

@jen-huang
Copy link
Contributor

I'm going to transfer this to SharedUX team. This is low priority from Fleet team's perspective since it is an edge case.

@jen-huang jen-huang added enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 14, 2023
@jen-huang jen-huang changed the title [Fleet] Generate a namespace prefix for Fleet's tags Generate a namespace prefix for managed tags Nov 14, 2023
@drewdaemon
Copy link
Contributor

drewdaemon commented Nov 20, 2023

@jen-huang if your team isn't interested in tracking this problem, I don't think we need to keep this issue open.

Fleet is the one creating the tags, so Fleet would be the team to make the changes adding the Elastic: prefix. I only mentioned Shared UX team in case you went the route of the prefix and wanted the tag system to stop customers from using the same prefix when they create their own tags, in which case that team could help.

@drewdaemon drewdaemon added Team:Fleet Team label for Observability Data Collection Fleet team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

5 participants