Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] Add managed indicator to library table #172388

Closed
Tracked by #172393
drewdaemon opened this issue Dec 1, 2023 · 10 comments · Fixed by #177089
Closed
Tracked by #172393

[Tags] Add managed indicator to library table #172388

drewdaemon opened this issue Dec 1, 2023 · 10 comments · Fixed by #177089
Assignees
Labels
enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@drewdaemon
Copy link
Contributor

Right now, users can't tell which tags they created vs which are managed by Elastic. We should add an indicator to the table at app/management/kibana/tags to make this clear.

@drewdaemon drewdaemon added enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Dec 1, 2023
@drewdaemon drewdaemon self-assigned this Dec 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@petrklapka
Copy link
Member

From triage Dec 18 - Seb & Vadim discussed approaches. @vadimkibana will reach out to Drew with feedback for Drew's implementation.

@drewdaemon
Copy link
Contributor Author

@MichaelMarcialis has suggested adding a lock icon next to badge component with a tooltip attached. @vadimkibana any objections?

@sebelga
Copy link
Contributor

sebelga commented Feb 6, 2024

Let's not forget that the naming can't collide. So "managed" might become "[elastic]-managed" which will clearly indicate. We can't just claim tags names anymore since we don't allow 2 tags with the same name. "managed" can already exist in a customer cluster.

@drewdaemon
Copy link
Contributor Author

drewdaemon commented Feb 6, 2024

@sebelga this issue only covers adding an indicator to the tags table so that users can tell which tags are installed by the system.

The issue you are describing was tracked in #171124. Feel free to reopen it if your team would like to take it on.

@sebelga
Copy link
Contributor

sebelga commented Feb 9, 2024

this issue only covers adding an indicator to the tags table so that users can tell which tags are installed by the system.

The fact that the tag names might all start by "[elastic-]" isn't a way to tell which tags are installed by the system already?

@drewdaemon
Copy link
Contributor Author

The way you can tell if a tag has been installed by fleet is by the presence of the managed SO property on that tag. Happy to sync if things aren't clear

@sebelga
Copy link
Contributor

sebelga commented Feb 9, 2024

We seem lost in translation 😄

You issue mentions: "Right now, users can't tell which tags they created vs which are managed by Elastic."

I am saying: "If all the tags managed by Elastic start with a [Elastic-] prefix, there isn't anything to do for this issue as the user will be able to tell the difference between their tags and the ones managed by Elastic by their names"

So the suggestion from Michael to "add a lock icon next to badge component" might not be needed.

@drewdaemon
Copy link
Contributor Author

drewdaemon commented Feb 9, 2024

@sebelga ah, thanks for clarifying... I follow now :)

My purpose in this project is to clarify the existing system to our users through new UI signifiers and limitations.

As you say, it could be that a tag naming scheme would do the trick on this page. However, getting Fleet to change their tag installation process and/or providing support from the shared UX side for a system prefix in tag names is outside the scope of what I'm trying to accomplish.

I hear you on the tag conflict concerns, but those already exist and the Fleet team isn't concerned: they see it as an edge case.

I feel that if your team wants to prioritize this case and coordinate with them they would be open to it. At that point, you could come in and replace these lock icons ;) But, like I say, it's outside the scope of my plan (though I would be happy to point you to the right people to talk to).

Given this explanation, are there any objections to the above proposal? (Also, happy to discuss more with you and/or the team).

@sebelga
Copy link
Contributor

sebelga commented Feb 12, 2024

Thanks for the context @drewdaemon 👍

Given this explanation, are there any objections to the above proposal?

No objections!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants