-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags] Add managed indicator to library table #172388
Comments
Pinging @elastic/appex-sharedux (Team:SharedUX) |
From triage Dec 18 - Seb & Vadim discussed approaches. @vadimkibana will reach out to Drew with feedback for Drew's implementation. |
@MichaelMarcialis has suggested adding a lock icon next to badge component with a tooltip attached. @vadimkibana any objections? |
Let's not forget that the naming can't collide. So "managed" might become "[elastic]-managed" which will clearly indicate. We can't just claim tags names anymore since we don't allow 2 tags with the same name. "managed" can already exist in a customer cluster. |
The fact that the tag names might all start by "[elastic-]" isn't a way to tell which tags are installed by the system already? |
The way you can tell if a tag has been installed by fleet is by the presence of the |
We seem lost in translation 😄 You issue mentions: "Right now, users can't tell which tags they created vs which are managed by Elastic." I am saying: "If all the tags managed by Elastic start with a So the suggestion from Michael to "add a lock icon next to badge component" might not be needed. |
@sebelga ah, thanks for clarifying... I follow now :) My purpose in this project is to clarify the existing system to our users through new UI signifiers and limitations. As you say, it could be that a tag naming scheme would do the trick on this page. However, getting Fleet to change their tag installation process and/or providing support from the shared UX side for a system prefix in tag names is outside the scope of what I'm trying to accomplish. I hear you on the tag conflict concerns, but those already exist and the Fleet team isn't concerned: they see it as an edge case. I feel that if your team wants to prioritize this case and coordinate with them they would be open to it. At that point, you could come in and replace these lock icons ;) But, like I say, it's outside the scope of my plan (though I would be happy to point you to the right people to talk to). Given this explanation, are there any objections to the above proposal? (Also, happy to discuss more with you and/or the team). |
Thanks for the context @drewdaemon 👍
No objections! |
Right now, users can't tell which tags they created vs which are managed by Elastic. We should add an indicator to the table at
app/management/kibana/tags
to make this clear.The text was updated successfully, but these errors were encountered: