[Custom threshold] How to handle percentage field for multiple aggregations

[maryam-saeidi]

@maryam-saeidi I think using a different unit for percentage metrics is confusing for user and we need to handle different scenarios when switching between percentage and non-percentage metrics. Also, how do we handle a scenario when all metrics in a condition are percentage.

Switching from average to count

Screen.Recording.2023-11-13.at.22.44.22.mov

Using both percentage metrics in a condition

Screen.Recording.2023-11-13.at.22.50.33.mov

Originally posted by @benakansara in #170306 (comment)

Questions

1. How to handle multiple aggregations when all the fields are percentages?
2. How to improve using experience when moving from percentage field to other fields or document count aggregation?
   One idea: not having a default value or changing the default value when the field changes (but we need to consider the case that the user already changed the threshold).

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[maryam-saeidi]

@maciejforcone Would you please help with the above two questions in this ticket?

[maciejforcone]

@maciejforcone Would you please help with the above two questions in this ticket?

I think it makes sense not to change the default, and user modified values, whenever user changes the condition type. Also we can think of "1" as a default threshold value, so it's "100%" for percentage only metrics.

[maryam-saeidi]

@benakansara I found a way to fix the first issue based on Maciej's input 🎉

Screen.Recording.2023-11-23.at.11.59.35.mov

[maciejforcone]

After consultations with @maryam-saeidi, we decided to go with defaulting the unit, but only when all aggregations have the same unit, otherwise we use a number (and in additional ticket, we will add user control for selecting the unit they want). So for example if all aggregations are % based, we add % as a unit, in the threshold field.