Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] Project names should be extended to reduce elipsis #170758

Closed
sixstringcode opened this issue Nov 7, 2023 · 2 comments · Fixed by #171515
Closed

[Serverless] Project names should be extended to reduce elipsis #170758

sixstringcode opened this issue Nov 7, 2023 · 2 comments · Fixed by #171515
Assignees
@Dosant
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@sixstringcode
Copy link

image

The max space allowed for project titles needs to be increased so that most project names can be displayed without being truncated.
@sixstringcode sixstringcode added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release labels Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant self-assigned this Nov 8, 2023
@Dosant Dosant mentioned this issue Nov 8, 2023
Closed
@Dosant
Copy link
Contributor

Dosant commented Nov 8, 2023

Looks like the max-width is not configurable, I opened an issue on EUI side elastic/eui#7349

we can also consider a quick hacky fix with css override

@Dosant Dosant mentioned this issue Nov 20, 2023
Merged
kibanamachine pushed a commit to nreese/kibana that referenced this issue Nov 21, 2023
@Dosant
[Serverless] Increase root breadcrumb width to reduce elipsis (elasti…
f4e0d83 
…c#171515)

## Summary

close elastic#170758

This PR increases root breadcrumb max width from 160 to 320px to fit
more of project titles. It also slightly adjusts number of visible
breadcrumbs per breakpoint to account for potentially 2x longer root
breadcrumb. Note that responsiveness is still not ideal as the system
doesn't actually calculate the width of each breadcrumb.


Before: 

<img width="1267" alt="Screenshot 2023-11-20 at 11 53 13"
src="https://github.com/elastic/kibana/assets/7784120/6d2ba8d2-5bc0-4f85-a87a-a4185ae901f7">


After: 

<img width="1284" alt="Screenshot 2023-11-20 at 11 52 31"
src="https://github.com/elastic/kibana/assets/7784120/90a57e58-6836-4465-a21e-78f72dc4953e">
@Dosant Dosant mentioned this issue Nov 22, 2023
Merged
darnautov pushed a commit to darnautov/kibana that referenced this issue Nov 23, 2023
@Dosant
[Serverless] Fix truncation in breadcrumbs (elastic#171770)
274b4f4 
## Summary

Fix truncation in breadcrumbs when the header doesn't fit:
https://css-tricks.com/flexbox-truncated-text/
I noticed this issue while working on
elastic#170758

(look at breadcrumbs)


https://github.com/elastic/kibana/assets/7784120/921339be-c018-4370-be2c-54ced982d0b2


Note: the root breadcrumb will be fixed with EUI update
elastic/eui#7375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Serverless] Increase root breadcrumb width to reduce elipsis Dosant/kibana
3 participants
@Dosant @elasticmachine @sixstringcode