-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] Allow data views created on hidden and system indices - second attempt #168882
[data views] Allow data views created on hidden and system indices - second attempt #168882
Conversation
…kibana into data_views_really_allow_hidden
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
…kibana into data_views_really_allow_hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both for looking into and addressing the wildcard issue! I pulled and tested again and can confirm the issue no longer exists. It seems hidden and system index data views are now fully supported, LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @mattkime |
The exceptions flake occurring seems to be completely unrelated to these changes. It's expecting one rule to show in the test instead of the two appearing for selection. Skipping and tracking in this PR here. |
Summary
Previously, the 'Allow hidden and system indices' advanced option when creating a data view was only a UI convenience. It allowed you to see which hidden and system indices you were matching but they would be would be selected just the same once the data view was loaded. At some point something changed and now there are system and hidden indices that require
expandWildcards: hidden
to be passed to field caps in order to see anything.allowHidden: boolean
is added to the DataView and DataViewSpec and passed through when field caps requests are made.This is primarily a tool for troubleshooting. For instance, instead of hitting a full data stream across a number of data tiers you can select a specific index to compare its performance.
NOTE: This is a second attempt. What I learned - the whole
expand_wildcards
param is literal - you can directly query a hidden index withoutexpandWildcards: hidden
since its not using a wildcard. Tests now use a wildcard.Closes: #164652