Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Allow data views created on hidden and system indices - second attempt #168882

Merged
merged 52 commits into from
Nov 14, 2023

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 13, 2023

Summary

Previously, the 'Allow hidden and system indices' advanced option when creating a data view was only a UI convenience. It allowed you to see which hidden and system indices you were matching but they would be would be selected just the same once the data view was loaded. At some point something changed and now there are system and hidden indices that require expandWildcards: hidden to be passed to field caps in order to see anything. allowHidden: boolean is added to the DataView and DataViewSpec and passed through when field caps requests are made.

This is primarily a tool for troubleshooting. For instance, instead of hitting a full data stream across a number of data tiers you can select a specific index to compare its performance.

NOTE: This is a second attempt. What I learned - the whole expand_wildcards param is literal - you can directly query a hidden index without expandWildcards: hidden since its not using a wildcard. Tests now use a wildcard.

Closes: #164652

@mattkime mattkime changed the title Data views really allow hidden [data views] Allow data views created on hidden and system indices - second attempt Oct 14, 2023
@mattkime mattkime self-assigned this Oct 14, 2023
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. release_note:skip Skip the PR/issue when compiling release notes labels Oct 14, 2023
@mattkime mattkime marked this pull request as ready for review October 14, 2023 02:51
@mattkime mattkime requested review from a team as code owners October 14, 2023 02:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime requested a review from a team as a code owner November 7, 2023 21:08
@mattkime mattkime requested a review from a team as a code owner November 9, 2023 14:55
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both for looking into and addressing the wildcard issue! I pulled and tested again and can confirm the issue no longer exists. It seems hidden and system index data views are now fully supported, LGTM 👍

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattkime mattkime enabled auto-merge (squash) November 10, 2023 13:47
@kertal
Copy link
Member

kertal commented Nov 14, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 14, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #6 / Add, edit and delete exception Add, Edit and delete Exception item should create exception item from Shared Exception List page and linked to a Rule should create exception item from Shared Exception List page and linked to a Rule
  • [job] [logs] Security Solution Cypress Tests #16 / Add, edit and delete exception Add, Edit and delete Exception item should create exception item from Shared Exception List page and linked to a Rule should create exception item from Shared Exception List page and linked to a Rule
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Add, edit and delete exception Add, Edit and delete Exception item should create exception item from Shared Exception List page and linked to a Rule should create exception item from Shared Exception List page and linked to a Rule
  • [job] [logs] Security Solution Cypress Tests #16 / Add, edit and delete exception Add, Edit and delete Exception item should create exception item from Shared Exception List page and linked to a Rule should create exception item from Shared Exception List page and linked to a Rule
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Add, edit and delete exception Add, Edit and delete Exception item should create exception item from Shared Exception List page and linked to a Rule should create exception item from Shared Exception List page and linked to a Rule
  • [job] [logs] Serverless Security Cypress Tests #6 / Add, edit and delete exception Add, Edit and delete Exception item should create exception item from Shared Exception List page and linked to a Rule should create exception item from Shared Exception List page and linked to a Rule

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2542 2545 +3
dataViews 255 257 +2
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 47.7KB 48.0KB +254.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 413.3KB 413.3KB +89.0B
dataViews 46.6KB 47.0KB +429.0B
total +518.0B
Unknown metric groups

API count

id before after diff
data 3193 3197 +4
dataViews 918 922 +4
total +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@yctercero
Copy link
Contributor

The exceptions flake occurring seems to be completely unrelated to these changes. It's expecting one rule to show in the test instead of the two appearing for selection. Skipping and tracking in this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data views] support hidden / system indices in data views