Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] All agent tags should be visible when agent list is filtered #164674

Closed
juliaElastic opened this issue Aug 24, 2023 · 6 comments · Fixed by #205163
Closed

[Fleet] All agent tags should be visible when agent list is filtered #164674

juliaElastic opened this issue Aug 24, 2023 · 6 comments · Fixed by #205163
Assignees
Labels
bug Fixes for quality problems that affect the customer experience 💝community good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@juliaElastic
Copy link
Contributor

Bug in 8.9 and possibly a few older minors.

After setting up tags for Elastic Agents in Kibana > Fleet UI, the tags created are not visible/available to add to an agent after a search for that agent specifically.
Steps to reproduce:

  • Add 2 agents
  • Add a tag1 on agent1
  • Filter on agent2
  • Try to add tag1 to agent2
    Expectation: tag1 should be visible in the list
    Actual: tag1 is not visible, probably because available tags are only queried for the filtered agent list

Workaround: type in tag1 manually to add

@juliaElastic juliaElastic added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@AdrianPavlik
Copy link

Hi can I take on this issue?

@kpollich
Copy link
Member

@AdrianPavlik sure feel free!

@AdrianPavlik
Copy link

AdrianPavlik commented Oct 31, 2023

Hi, I would like to ask. I got the app started but, do I actually need to create an account to contribute to the project?

image

@MakoWish
Copy link

Is that the Elastic Package stack you are trying to log into? If so, it is just elastic:changeme.

@AdrianPavlik
Copy link

Great that works thanks for the help!

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 2, 2025
…205163)

## Summary

Closes elastic#164674

Remove `kuery` in request parameters to get all agents tags.

![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)

(cherry picked from commit a921224)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 2, 2025
…205163)

## Summary

Closes elastic#164674

Remove `kuery` in request parameters to get all agents tags.

![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)

(cherry picked from commit a921224)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 2, 2025
…205163)

## Summary

Closes elastic#164674

Remove `kuery` in request parameters to get all agents tags.

![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)

(cherry picked from commit a921224)
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 2, 2025
kibanamachine added a commit that referenced this issue Jan 2, 2025
…05163) (#205390)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Fix show all agent tags when agent list is filtered
(#205163)](#205163)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T13:43:59Z","message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet]
Fix show all agent tags when agent list is
filtered","number":205163,"url":"https://github.com/elastic/kibana/pull/205163","mergeCommit":{"message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205163","number":205163,"mergeCommit":{"message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7"}}]}]
BACKPORT-->

Co-authored-by: Jusheng Huang <[email protected]>
kibanamachine added a commit that referenced this issue Jan 2, 2025
…205163) (#205388)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Fleet] Fix show all agent tags when agent list is filtered
(#205163)](#205163)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T13:43:59Z","message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet]
Fix show all agent tags when agent list is
filtered","number":205163,"url":"https://github.com/elastic/kibana/pull/205163","mergeCommit":{"message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205163","number":205163,"mergeCommit":{"message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7"}}]}]
BACKPORT-->

Co-authored-by: Jusheng Huang <[email protected]>
kibanamachine added a commit that referenced this issue Jan 2, 2025
…205163) (#205389)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Fleet] Fix show all agent tags when agent list is filtered
(#205163)](#205163)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T13:43:59Z","message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet]
Fix show all agent tags when agent list is
filtered","number":205163,"url":"https://github.com/elastic/kibana/pull/205163","mergeCommit":{"message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205163","number":205163,"mergeCommit":{"message":"[Fleet]
Fix show all agent tags when agent list is filtered (#205163)\n\n##
Summary\r\n\r\nCloses #164674 \r\n\r\nRemove `kuery` in request
parameters to get all agents
tags.\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/229ac48b-e33e-4c2d-8062-04ce6dc86c2a)","sha":"a92122425e2b73cdde2e1481bf1f29e2059b0ec7"}}]}]
BACKPORT-->

Co-authored-by: Jusheng Huang <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Jan 2, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience 💝community good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
5 participants