-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV reporting service for exporting ML notifications #145082
Comments
Pinging @elastic/ml-ui (:ml) |
Hi @darnautov! Thanks for creating this issue. A few questions:
ping @elastic/kibana-global-experience |
hi @tsullivan! The number of rows depends on:
Not sure about the shards, perhaps @dimitris-athanasiou or @droberts195 could answer that. |
1 or 2. Might be 3 in the future. We create a new notifications index each time we change the mappings, and so far we've done that once. Each index is set up to have 1 shard. |
Hi @darnautov and @droberts195 I'd like to refer you to a writeup on CSV export thoughts here. In the writeup, I mention that we chose the best option available to us for CSV export, but it is known to be not perfect. Since it is not async search, there could be timeout problems that need to be carefully handled. When we export the CSV from Discover, it creates a report artifact, and runs search in a background task where timeouts are carefully handled and bubbled up to the user in the form of a warning in the report job. In the Reporting domain, there is another feature that lets the user download CSV from an API, without creating a report job artifact. My hope is that we can deprecate that feature, simplify the code paths in Reporting, and just use report jobs for everything. I think that will benefit you as well: the better handling of timeouts and error tracking will make it easier for support / developers when issues happen. I believe the use case of having some kind of post-filter can still be supported. My sense of how it would work, we can create a new "export type" for this use case to register with the Reporting plugin. When the user wants to download the ML notifications, they would see a popup that a search job is running in the background, and then another popup containing a download link would show when it is ready. They could later go to Does this make sense, and does it sound OK? |
We'd like to utilize the CSV reporting service for exporting ML notifications. The existing solution should be updated to account for the following requirements.
.ml-notifications*
index, i.e. ML notifications are not Kibana saved objects.my_ml_job
, hence for space-aware requirements, regular ES filter in the query might not suffice and the service should support custom filters.The text was updated successfully, but these errors were encountered: