-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Allow users to configure CCS pattern #120384
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
@simianhacker will this also allow for more than one remote cluster, in case they can't be written with a wildcard pattern? |
@crisdarocha That's a great question, I think in that case we would need a way to create multiple patterns. Maybe instead of a string it's an array like this:
Which would set the index patterns for queries to this:
|
We might want to be careful about path length explosion if we enable multiple patterns (rel #118646). ES has a 4k line length default on I doubt we'll hit it if we keep it under 10 patterns or so though. |
The array sounds like a nice solution. Specially in ESS where deployments can have the most unexpected names. |
Open question: Should the default for CCS enabled be "true"? |
@jasonrhodes I would vote NO. I feel like CCS is sufficiently complicated that enabling it by default just causes more problems than it solves. The worst case is when a someone adds a remote host for a different purpose, they visit Stack Monitoring to look at their cluster and things stop working because the requests fail. It's especially bad when the remote cluster has a HUGE Metricbeat installation which causes Stack Monitoring to timeout. Another scenario is when they deploy their nodes via some orchestration framework which has an option for the node roles and they omit I would prefer if there was explicit instructions for enabling CCS for Stack Monitoring. |
+1 to @simianhacker 's sentiment. While it was kind of "oh awesome" to see the that CSS "just worked" when connecting our internal monitoring clusters (cloud.elastic.co managed), I don't think that it was enough of a win to make the potential problems worth it. |
+1 on @simianhacker's comment too. I think the risks of having it by default are surely high. Not sure how it's done in ESS though. I can't see the settings myself, but I believe ESS has this by default and changing it requires an override. |
@ravikesarwani Do you have any opinion on possibly turning CCS off by default? We're going to leave it as true for now and see if a combination of having removed |
Hey all! I just had a good chat with @neptunian about these changes and I asked if we can hold off on merging them for right now. She's going to merge some of her changes (after review) that will make it easier to enable this type of config in the future, but I want to hold off on introducing another configuration flag that we will have to maintain for a long time when the future of index selection across observability is currently under a lot of review (data views, saved views, saved searches, ESQL, etc etc). So with that in mind, in order to avoid locking us into a config flag that controls just a part of the index selection required for all Stack Monitoring queries, we're going to hold off on introducing the flag. In addition, since we removed the metricbeat indices from our SM queries, there's a good chance users won't run into the problem where this is most dramatic, so we can hold off until we see if that's a true assumption or not as well. Again, if we find a set of customers that have the issue and need this flag, we'll be able to bring it back much more easily now that Sandy has done the investigation and most of the implementation work. Let me know if you have questions about this! |
Opened a new PR #130466 |
Other issues that need to be addressed before moving forward
See draft PR #129806 for implementation |
Maybe it's useful to recapitulate some advantages and disadvantages of Kibana's Advanced Settings: Advantages
Disadvantages
On the topic of supporting data views, both Advanced settings and the |
I suppose an advantage of the Advanced Setting is that, through migration, we could potentially create a Data View for a customer who had configured this setting previously. With the kibana.yml config value, I suppose we could do something similar, but at start up instead? I wonder if the deprecation process for Advanced Settings is substantially different than deprecating a kibana.yml config value. I'm of two minds here because on the one hand it feels like overthinking things to be worried about something that might happen down the road re: switching to data views etc in Stack Monitoring, but on the other hand it really feels like index selection should be handled differently than concatenating strings stored in different places and in different ways, further separating ourselves from the rest of Kibana. Based on that, I think we should plan a short R&D and investigate what it would look like to use Data Views in Stack Monitoring, so that we can remove some of that existing separation and potentially provide better ways for users to "fix" this remote CCS problem (I'm not sure if Data Views will help a ton here, but I'd like to explore it). |
Thank you, @neptunian! |
When Stack Monitoring queries indices with
monitoring.ui.ccs.enabled: true
, which is the default, we use the*:
pattern. This means that it will query ALL of their remote CCS clusters, this can be problematic for users with multiple remote clusters.Currently the only option is for users to hack around this limitation using the following settings in
kibana.yml
:Ideally we would rather have users use this:
AC:
monitoring.ui.ccs.remotePattern
which defaults to*
The text was updated successfully, but these errors were encountered: