-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Observability Solution][Maintenance] Move to Emotion CSS, enable Tel…
…emetry and i18n ESLint rules for all Obs plugins (#177785) ## Summary This does two things: * Moves to Emotion CSS from .scss files * Enables Telemetry and i18n ESLint rules for all Observability apps ## Why? **Move to Emotion CSS** There were four .scss files total in the 17 Observability plugins. Two of them were empty. The remaining two had one class each. By removing the two empty files and moving to Emotion, we can remove the lines pertaining to .scss files in the CODEOWNERS file. **Enabling Telemetry and i18n ESLint rules for all Observability apps** One of the reasons for consolidating Obs apps into one folder was to create a more consistent development experience across apps in the Observability org. By changing the eslint rule config to enable the [Telemetry](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-telemetry) and [i18n](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-i18n) ESLint rules on all `.ts` and `tsx` files in `observability_solution`, we enable the rule for 5 apps that did not have them enabled before and we ensure that the rule will immediately be enabled on new Observability applications at the moment of creation. ## Related PRs: - [x] [Move APM ](#177433) - [x] [Move Data Quality](#177456) - [x] [Move Exploratory View](#177440) - [x] [Move Infra](#177443) - [X] Move Logs Explorer - [x] [Move Logs Shared](#177735) - [x] [Move Observability AI Assistant](#177427) - [x] [Move Observability App](#177437) - [x] [Move Observability Onboarding](#177458) - [x] [Move Observability Shared](#177463) - [x] [Move Profiling](#177453) - [x] [Move Synthetics](#177464) - [x] [Move Uptime](#177466) - [x] [Move UX](#177470) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Marco Antonio Ghiani <[email protected]>
- Loading branch information
1 parent
98aff21
commit fbc544d
Showing
17 changed files
with
34 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
...bservability_solution/logs_explorer/public/components/virtual_columns/virtual_column.scss
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
...vability_solution/observability/public/pages/overview/components/news_feed/news_feed.scss
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters