Skip to content

Commit

Permalink
[8.15] [kbn-repo-packages] Add sort locale (#199138) (#199196)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.15`:
- [[kbn-repo-packages] Add sort locale
(#199138)](#199138)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T17:53:23Z","message":"[kbn-repo-packages]
Add sort locale (#199138)\n\nIn some situations `yarn kbn bootstrap` is
causing the sort order of\r\ntsconfig.base.json to change.\r\n\r\nThis
adds a locale to the comparative to keep the sort order
consistent.","sha":"935c3aa974a22e99a3284a7969217306ba5f3609","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"title":"[kbn-repo-packages]
Add sort
locale","number":199138,"url":"https://github.com/elastic/kibana/pull/199138","mergeCommit":{"message":"[kbn-repo-packages]
Add sort locale (#199138)\n\nIn some situations `yarn kbn bootstrap` is
causing the sort order of\r\ntsconfig.base.json to change.\r\n\r\nThis
adds a locale to the comparative to keep the sort order
consistent.","sha":"935c3aa974a22e99a3284a7969217306ba5f3609"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199138","number":199138,"mergeCommit":{"message":"[kbn-repo-packages]
Add sort locale (#199138)\n\nIn some situations `yarn kbn bootstrap` is
causing the sort order of\r\ntsconfig.base.json to change.\r\n\r\nThis
adds a locale to the comparative to keep the sort order
consistent.","sha":"935c3aa974a22e99a3284a7969217306ba5f3609"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
  • Loading branch information
kibanamachine and jbudz authored Nov 6, 2024
1 parent 79d00ab commit f11c3a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/kbn-repo-packages/modern/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Package {
* @param {Package} b
*/
static sorter(a, b) {
return a.manifest.id.localeCompare(b.manifest.id);
return a.manifest.id.localeCompare(b.manifest.id, 'en');
}

/**
Expand Down

0 comments on commit f11c3a4

Please sign in to comment.