Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] [Core Rendering Styles] Fix bug with kibanaFullBodyHeight calcu…
…lation (#193798) (#195146) # Backport This will backport the following commits from `main` to `8.x`: - [[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation (#193798)](#193798) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T21:00:57Z","message":"[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation (#193798)\n\nA variable for the page height was not being calculated correctly when\r\nthe Kibana chrome is invisible. This PR fixes the issue by adding `px`\r\nas a unit to a variable used as input in the calculation.\r\n\r\nUnblocks: https://github.com/elastic/kibana/pull/193647\r\n\r\n## Testing\r\nIt will help to test within the\r\nhttps://github.com//pull/193647 PR branch. The following\r\nscreenshots show the before and after effects of having this fix:\r\n\r\n**before**\r\n\r\n![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)\r\n\r\n**after**\r\n\r\n![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"1df458d2d605f5a3281c3b18bda9f433d41a7c05","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation","number":193798,"url":"https://github.com/elastic/kibana/pull/193798","mergeCommit":{"message":"[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation (#193798)\n\nA variable for the page height was not being calculated correctly when\r\nthe Kibana chrome is invisible. This PR fixes the issue by adding `px`\r\nas a unit to a variable used as input in the calculation.\r\n\r\nUnblocks: https://github.com/elastic/kibana/pull/193647\r\n\r\n## Testing\r\nIt will help to test within the\r\nhttps://github.com//pull/193647 PR branch. The following\r\nscreenshots show the before and after effects of having this fix:\r\n\r\n**before**\r\n\r\n![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)\r\n\r\n**after**\r\n\r\n![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"1df458d2d605f5a3281c3b18bda9f433d41a7c05"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193798","number":193798,"mergeCommit":{"message":"[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation (#193798)\n\nA variable for the page height was not being calculated correctly when\r\nthe Kibana chrome is invisible. This PR fixes the issue by adding `px`\r\nas a unit to a variable used as input in the calculation.\r\n\r\nUnblocks: https://github.com/elastic/kibana/pull/193647\r\n\r\n## Testing\r\nIt will help to test within the\r\nhttps://github.com//pull/193647 PR branch. The following\r\nscreenshots show the before and after effects of having this fix:\r\n\r\n**before**\r\n\r\n![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)\r\n\r\n**after**\r\n\r\n![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Marco Vettorello <[email protected]>","sha":"1df458d2d605f5a3281c3b18bda9f433d41a7c05"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
- Loading branch information