-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add SLO create callout to service overview, transactions page and tra…
…nsactions details (#159958) We split the work for #157484 into this PR and another one that will add the links to create SLOs from the Alerts and Rules dropdown in APM. Also, the design for the callout was simplified and we will iterate again in 8.10 ### What was done Added callout with links to create SLOs in service overview, transactions overview and transaction details. https://github.com/elastic/kibana/assets/31922082/00f55477-d1ae-4e42-bf7d-2f0af5a5307b --------- Co-authored-by: kibanamachine <[email protected]>
- Loading branch information
1 parent
45a9274
commit ea0935f
Showing
5 changed files
with
170 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
x-pack/plugins/apm/public/components/shared/slo_callout/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import { | ||
| EuiButton, | ||
| EuiCallOut, | ||
| EuiFlexGroup, | ||
| EuiFlexItem, | ||
| EuiLink, | ||
| } from '@elastic/eui'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { CreateSLOInput } from '@kbn/slo-schema'; | ||
| import { encode } from '@kbn/rison'; | ||
| import React from 'react'; | ||
| import { FormattedMessage } from '@kbn/i18n-react'; | ||
| import { useApmPluginContext } from '../../../context/apm_plugin/use_apm_plugin_context'; | ||
|
|
||
| interface Props { | ||
| dismissCallout: () => void; | ||
| serviceName: string; | ||
| environment: string; | ||
| transactionType?: string; | ||
| transactionName?: string; | ||
| } | ||
| type RecursivePartial<T> = { | ||
| [P in keyof T]?: T[P] extends Array<infer U> | ||
| ? Array<RecursivePartial<U>> | ||
| : T[P] extends object | undefined | ||
| ? RecursivePartial<T[P]> | ||
| : T[P]; | ||
| }; | ||
|
|
||
| export function SloCallout({ | ||
| dismissCallout, | ||
| serviceName, | ||
| environment, | ||
| transactionType, | ||
| transactionName, | ||
| }: Props) { | ||
| const { core } = useApmPluginContext(); | ||
| const { basePath } = core.http; | ||
|
|
||
| const sloInput: RecursivePartial<CreateSLOInput> = { | ||
| indicator: { | ||
| type: 'sli.apm.transactionErrorRate', | ||
| params: { | ||
| service: serviceName, | ||
| environment, | ||
| transactionName: transactionName ?? '', | ||
| transactionType: transactionType ?? '', | ||
| }, | ||
| }, | ||
| }; | ||
| const sloParams = `?_a=${encode(sloInput)}`; | ||
|
|
||
| return ( | ||
| <EuiCallOut | ||
| title={i18n.translate('xpack.apm.slo.callout.title', { | ||
| defaultMessage: 'Respond quicker with SLOs', | ||
| })} | ||
| iconType="lock" | ||
| > | ||
| <EuiFlexGroup direction="row" gutterSize="s" alignItems="center"> | ||
| <EuiFlexItem> | ||
| <p> | ||
| <FormattedMessage | ||
| id="xpack.apm.slo.callout.description" | ||
| defaultMessage="How quickly will you respond if the service goes down? Keep the performance, speed and user experience high with a SLO" | ||
| /> | ||
| </p> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem grow={false}> | ||
| <EuiFlexGroup> | ||
| <EuiFlexItem> | ||
| <EuiLink | ||
| data-test-subj="apmCreateSloLink" | ||
| href={basePath.prepend( | ||
| `/app/observability/slos/create${sloParams}` | ||
| )} | ||
| > | ||
| <EuiButton | ||
| data-test-subj="apmSloCalloutCreateSloButton" | ||
| onClick={() => { | ||
| dismissCallout(); | ||
| }} | ||
| > | ||
| {i18n.translate('xpack.apm.slo.callout.createButton', { | ||
| defaultMessage: 'Create SLO', | ||
| })} | ||
| </EuiButton> | ||
| </EuiLink> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem> | ||
| <EuiButton | ||
| color="text" | ||
| data-test-subj="apmSloDismissButton" | ||
| onClick={() => { | ||
| dismissCallout(); | ||
| }} | ||
| > | ||
| {i18n.translate('xpack.apm.slo.callout.dimissButton', { | ||
| defaultMessage: 'Hide this', | ||
| })} | ||
| </EuiButton> | ||
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| </EuiCallOut> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters