Fixes

elastic · Jan 3, 2025 · e82dcfe · e82dcfe
1 parent 50cbe35
commit e82dcfe
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/dev/eslint/types.eslint.config.template.cjs b/src/dev/eslint/types.eslint.config.template.cjs
@@ -34,5 +34,11 @@ module.exports = {
         '@typescript-eslint/no-floating-promises': 'error',
       },
     },
+    {
+      files: ['*spaces_api_integration/deployment_agnostic/services/basic_auth_supertest.ts'],
+      rules: {
+        '@typescript-eslint/no-floating-promises': 'off',
+      },
+    },
   ],
 };
diff --git a/x-pack/test/spaces_api_integration/common/suites/copy_to_space.agnostic.ts b/x-pack/test/spaces_api_integration/common/suites/copy_to_space.agnostic.ts
@@ -822,12 +822,12 @@ export function copyToSpaceTestSuiteFactory(context: DeploymentAgnosticFtrProvid
           await supertest.destroy();
         });
 
-        describe.skip('single-namespace types', () => {
+        describe('single-namespace types', () => {
           beforeEach(
             async () => await testDataLoader.createFtrSavedObjectsData(SPACE_DATA_TO_LOAD)
           );
 
-          afterEach(async () => await await testDataLoader.deleteFtrSavedObjectsData());
+          afterEach(async () => await testDataLoader.deleteFtrSavedObjectsData());
 
           const dashboardObject = { type: 'dashboard', id: `cts_dashboard_${spaceId}` };
 
@@ -957,7 +957,7 @@ export function copyToSpaceTestSuiteFactory(context: DeploymentAgnosticFtrProvid
           [false, false],
           [false, true], // createNewCopies enabled
           [true, false], // overwrite enabled
-          // we don't specify tese cases with both overwrite and createNewCopies enabled, since overwrite won't matter in that scenario
+          // we don't specify test cases with both overwrite and createNewCopies enabled, since overwrite won't matter in that scenario
         ].forEach(([overwrite, createNewCopies]) => {
           const spaces = ['space_2'];
           const includeReferences = false;

diff --git a/x-pack/test/spaces_api_integration/deployment_agnostic/services/basic_auth_supertest.ts b/x-pack/test/spaces_api_integration/deployment_agnostic/services/basic_auth_supertest.ts
@@ -26,7 +26,7 @@ export class SupertestWithBasicAuth {
     const agent = this.supertestWithoutAuth[method](url);
 
     if (this.user) {
-      agent.auth(this.user.username!, this.user.password!).catch(() => {}); // to silence @typescript-eslint/no-floating-promises;
+      agent.auth(this.user.username!, this.user.password!);
     }
 
     return agent;