-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Bedrock chat] Fixes for BedrockChat model + tools (#189227)
## Summary BedrockChat was not working as expected when triggering the tools. For example, trying to invoke alerts tools caused this error: <img width="1059" alt="Screenshot 2024-07-25 at 11 21 52 AM" src="https://github.com/user-attachments/assets/fe302d41-482c-4a65-abc1-8d669abf928d"> This was not a helpful or proper error message to display. I fixed error handling to bubble up the correct error: <img width="857" alt="Screenshot 2024-07-25 at 11 26 08 AM" src="https://github.com/user-attachments/assets/a4135269-6bcb-436f-bd17-f817c06f3778"> This error has something to do with the BedrockChat model not working properly. @jacoblee93 is looking into a fix on the LC side. In the meantime, I changed the prompt around and was able to coerce the correct responses out of Sonnet 3.5 and Opus for the ESQL and RAG alerts questions James was testing with: <img width="1708" alt="alerts-opus" src="https://github.com/user-attachments/assets/47df0500-6e2f-477b-a3b9-da792f1d9b03"> <img width="1510" alt="alerts-sonnet" src="https://github.com/user-attachments/assets/0efd5519-196b-4309-9300-194196e5dde3"> <img width="1573" alt="esql-opus" src="https://github.com/user-attachments/assets/d7f519be-262c-4767-9d84-3fcb4fde089c"> <img width="1580" alt="Screenshot 2024-07-25 at 3 40 05 PM" src="https://github.com/user-attachments/assets/9d408ab8-2fd5-4bbb-bb2e-bb54e0277717">
- Loading branch information
1 parent
0a1db30
commit dd9e94d
Showing
3 changed files
with
48 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters