Skip to content

Commit

Permalink
[SLOs] Fix matching path for slo in observability nav !! (#194186)
Browse files Browse the repository at this point in the history
## Summary

### Before

notice slo is not selected

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/08068de6-5b1d-4f37-b55d-aace8c56aa79">


### After
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/378d9141-3726-41e0-8256-10f2149b9eb2">
  • Loading branch information
shahzad31 authored Sep 26, 2024
1 parent ea220bf commit dbbbde8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export class Plugin
defaultMessage: 'SLOs',
}),
app: 'slo',
path: '/',
path: '',
},
]
: [];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const getDataViewId = (searchConfiguration?: SearchConfigurationWithExtractedRef
? searchConfiguration.index
: searchConfiguration?.index?.title;

export const registerObservabilityRuleTypes = async (
export const registerObservabilityRuleTypes = (
observabilityRuleTypeRegistry: ObservabilityRuleTypeRegistry,
uiSettings: IUiSettingsClient,
logsExplorerLocator?: LocatorPublic<LogsExplorerLocatorParams>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const sloBurnRateDefaultRecoveryMessage = i18n.translate(
}
);

export const registerBurnRateRuleType = async (
export const registerBurnRateRuleType = (
observabilityRuleTypeRegistry: ObservabilityRuleTypeRegistry
) => {
observabilityRuleTypeRegistry.register({
Expand Down

0 comments on commit dbbbde8

Please sign in to comment.