Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
# Backport This will backport the following commits from `main` to `8.x`: - [[SharedUX] Replace Sass with Emotion, Round 1 (#199885)](#199885) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-04T17:39:22Z","message":"[SharedUX] Replace Sass with Emotion, Round 1 (#199885)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nSelects certain Sass files to replace with styles declared with Emotion.\r\nThis PR does not include any changes that would be noticeable by\r\nend-users. It changes the internals to use a different technology for\r\nstyling components.\r\n\r\n~~Some `className` attributes have been kept, because they are\r\nreferenced in JS and tests.~~ Update: all classNames that are no longer\r\nneeded for styling purposes have been removed.\r\n* If the className was needed for tests, it has been replaced with a\r\ntest-subj.\r\n* If the className was used as a selector in production code, it has\r\nbeen replaced with alternative JS.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2. https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360\r\n\r\n---------\r\n\r\nCo-authored-by: Jatin Kathuria <[email protected]>","sha":"d86896bac0bbc5ed48b43e695e0a73c55b21450c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","backport:prev-minor"],"number":199885,"url":"https://github.com/elastic/kibana/pull/199885","mergeCommit":{"message":"[SharedUX] Replace Sass with Emotion, Round 1 (#199885)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nSelects certain Sass files to replace with styles declared with Emotion.\r\nThis PR does not include any changes that would be noticeable by\r\nend-users. It changes the internals to use a different technology for\r\nstyling components.\r\n\r\n~~Some `className` attributes have been kept, because they are\r\nreferenced in JS and tests.~~ Update: all classNames that are no longer\r\nneeded for styling purposes have been removed.\r\n* If the className was needed for tests, it has been replaced with a\r\ntest-subj.\r\n* If the className was used as a selector in production code, it has\r\nbeen replaced with alternative JS.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2. https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360\r\n\r\n---------\r\n\r\nCo-authored-by: Jatin Kathuria <[email protected]>","sha":"d86896bac0bbc5ed48b43e695e0a73c55b21450c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199885","number":199885,"mergeCommit":{"message":"[SharedUX] Replace Sass with Emotion, Round 1 (#199885)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nSelects certain Sass files to replace with styles declared with Emotion.\r\nThis PR does not include any changes that would be noticeable by\r\nend-users. It changes the internals to use a different technology for\r\nstyling components.\r\n\r\n~~Some `className` attributes have been kept, because they are\r\nreferenced in JS and tests.~~ Update: all classNames that are no longer\r\nneeded for styling purposes have been removed.\r\n* If the className was needed for tests, it has been replaced with a\r\ntest-subj.\r\n* If the className was used as a selector in production code, it has\r\nbeen replaced with alternative JS.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2. https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360\r\n\r\n---------\r\n\r\nCo-authored-by: Jatin Kathuria <[email protected]>","sha":"d86896bac0bbc5ed48b43e695e0a73c55b21450c"}}]}] BACKPORT-->
- Loading branch information