Skip to content

Commit

Permalink
[8.x] [ML] AIOps: fixing time range filter in change point chart (#20…
Browse files Browse the repository at this point in the history
…0183) (#200303)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] AIOps: fixing time range filter in change point chart
(#200183)](#200183)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-15T13:59:00Z","message":"[ML]
AIOps: fixing time range filter in change point chart (#200183)\n\nThe
[range\r\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/8.16/query-dsl-range-query.html)\r\ntakes
`gte` and `lte` rather than `from` and `to`.\r\nThese are now being
flagged up in the kibana
readiness\r\n[report](elastic/kibana-team#1173)
as being\r\ndeprecate, although they never seem to be have been
supported.\r\n\r\nIt is unclear if this query was working as expected,
but there appears\r\nto be no change in the chart when switching to the
correct properties.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b59136295c25d4a3ffe4871c013d8469da201ffb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:ML/AIOps","backport:version","v8.17.0"],"title":"[ML]
AIOps: fixing time range filter in change point
chart","number":200183,"url":"https://github.com/elastic/kibana/pull/200183","mergeCommit":{"message":"[ML]
AIOps: fixing time range filter in change point chart (#200183)\n\nThe
[range\r\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/8.16/query-dsl-range-query.html)\r\ntakes
`gte` and `lte` rather than `from` and `to`.\r\nThese are now being
flagged up in the kibana
readiness\r\n[report](elastic/kibana-team#1173)
as being\r\ndeprecate, although they never seem to be have been
supported.\r\n\r\nIt is unclear if this query was working as expected,
but there appears\r\nto be no change in the chart when switching to the
correct properties.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b59136295c25d4a3ffe4871c013d8469da201ffb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200183","number":200183,"mergeCommit":{"message":"[ML]
AIOps: fixing time range filter in change point chart (#200183)\n\nThe
[range\r\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/8.16/query-dsl-range-query.html)\r\ntakes
`gte` and `lte` rather than `from` and `to`.\r\nThese are now being
flagged up in the kibana
readiness\r\n[report](elastic/kibana-team#1173)
as being\r\ndeprecate, although they never seem to be have been
supported.\r\n\r\nIt is unclear if this query was working as expected,
but there appears\r\nto be no change in the chart when switching to the
correct properties.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b59136295c25d4a3ffe4871c013d8469da201ffb"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
  • Loading branch information
kibanamachine and jgowdyelastic authored Nov 15, 2024
1 parent d951a4e commit d7c2de7
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ export const ChartGridEmbeddableWrapper: FC<ChangePointDetectionProps> = ({
mergedQuery.bool.filter.push({
range: {
[dataView.timeFieldName!]: {
from: searchBounds.min?.valueOf(),
to: searchBounds.max?.valueOf(),
gte: searchBounds.min?.valueOf(),
lte: searchBounds.max?.valueOf(),
format: 'epoch_millis',
},
},
Expand Down

0 comments on commit d7c2de7

Please sign in to comment.