Skip to content

Commit

Permalink
[8.15] [ML] Removes info callout mentioning ML nodes for serverless e…
Browse files Browse the repository at this point in the history
…nvironment (#187583) (#187620)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Removes info callout mentioning ML nodes for serverless
environment (#187583)](#187583)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-05T07:19:51Z","message":"[ML]
Removes info callout mentioning ML nodes for serverless environment
(#187583)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/187575\r\n\r\nRemove an info
callout mentioning the number of ML nodes for
serverless\r\nenvironment","sha":"3a9b01cf2201d749fb7bab034d6745db93bfdc82","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Team:ML","v8.15.0","v8.16.0"],"title":"[ML]
Removes info callout mentioning ML nodes for serverless environment
","number":187583,"url":"https://github.com/elastic/kibana/pull/187583","mergeCommit":{"message":"[ML]
Removes info callout mentioning ML nodes for serverless environment
(#187583)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/187575\r\n\r\nRemove an info
callout mentioning the number of ML nodes for
serverless\r\nenvironment","sha":"3a9b01cf2201d749fb7bab034d6745db93bfdc82"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187583","number":187583,"mergeCommit":{"message":"[ML]
Removes info callout mentioning ML nodes for serverless environment
(#187583)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/187575\r\n\r\nRemove an info
callout mentioning the number of ML nodes for
serverless\r\nenvironment","sha":"3a9b01cf2201d749fb7bab034d6745db93bfdc82"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
3 people authored Jul 9, 2024
1 parent 28ee744 commit d765ed3
Showing 1 changed file with 18 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
requiredValidator,
} from '../../../common/util/validators';
import type { ModelItem } from './models_list';
import { useEnabledFeatures } from '../contexts/ml';

interface DeploymentSetupProps {
config: ThreadingParams;
Expand Down Expand Up @@ -373,6 +374,8 @@ export const StartUpdateDeploymentModal: FC<StartDeploymentModalProps> = ({
initialParams,
modelAndDeploymentIds,
}) => {
const { showNodeInfo } = useEnabledFeatures();

const isUpdate = !!initialParams;

const { total_ml_processors: totalMlProcessors } = getNewJobLimits();
Expand Down Expand Up @@ -441,18 +444,22 @@ export const StartUpdateDeploymentModal: FC<StartDeploymentModalProps> = ({
</EuiModalHeader>

<EuiModalBody>
<EuiCallOut
size={'s'}
title={
<FormattedMessage
id="xpack.ml.trainedModels.modelsList.startDeployment.maxNumOfProcessorsWarning"
defaultMessage="The product of the number of allocations and threads per allocation should be less than the total number of processors on your ML nodes."
{showNodeInfo ? (
<>
<EuiCallOut
size={'s'}
title={
<FormattedMessage
id="xpack.ml.trainedModels.modelsList.startDeployment.maxNumOfProcessorsWarning"
defaultMessage="The product of the number of allocations and threads per allocation should be less than the total number of processors on your ML nodes."
/>
}
iconType="iInCircle"
color={'primary'}
/>
}
iconType="iInCircle"
color={'primary'}
/>
<EuiSpacer size={'m'} />
<EuiSpacer size={'m'} />
</>
) : null}

<DeploymentSetup
config={config}
Expand Down

0 comments on commit d765ed3

Please sign in to comment.