-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unskip TSVB to Lens functional test (#179858)
## Summary Fixes #179307 and speeds up a bit the `resetPage` method when possible via click on the `Visualize list` navigation breadcrumb on the top left: <img width="289" alt="Screenshot 2024-04-04 at 09 56 37" src="https://github.com/elastic/kibana/assets/924948/74011b51-34b1-4cfa-a78e-4224a3494a25"> The work on `navigateToNewVisualization` (function called by `resetPage`) had some side effects for some tests where a uiSettings changes were used as shortcut for the time picker: in such case a `forceRefresh` option has been provided now to cover it, but I may suggest to reduce the usage as much as possible. The new change lead to an average of ~5 minutes saving only within the `open_in_lens/tsvb` test suite, but it is a rough number as the average between the savings on the CI on the flaky runner. Probably there's an extra saving on other test suites as well. Flaky runner for the `Open in Lens/TSVB` test suite (50x runs): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5604 Flaky runner for the `Lens - Group5` test suite (50x runs): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5606#_ ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- Loading branch information
Showing
4 changed files
with
40 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters