Skip to content

Commit

Permalink
Merge branch 'main' into 192115-apmotel-add-synthtrace-scenarios-to-t…
Browse files Browse the repository at this point in the history
…est-with-otel-data
  • Loading branch information
jennypavlova authored Oct 7, 2024
2 parents 0d08420 + 149c514 commit d5d9eb0
Show file tree
Hide file tree
Showing 204 changed files with 3,538 additions and 900 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
spec:
env:
SLACK_NOTIFICATIONS_CHANNEL: '#kibana-operations-alerts'
GITHUB_BUILD_COMMIT_STATUS_ENABLED: 'true'
ELASTIC_GITHUB_BUILD_COMMIT_STATUS_ENABLED: 'true'
GITHUB_COMMIT_STATUS_CONTEXT: buildkite/on-merge
REPORT_FAILED_TESTS_TO_GITHUB: 'true'
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true'
Expand Down
6 changes: 3 additions & 3 deletions .buildkite/pipeline-resource-definitions/kibana-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ spec:
description: Runs manually for pull requests
spec:
env:
PR_COMMENTS_ENABLED: 'true'
GITHUB_BUILD_COMMIT_STATUS_ENABLED: 'true'
ELASTIC_PR_COMMENTS_ENABLED: 'true'
ELASTIC_GITHUB_BUILD_COMMIT_STATUS_ENABLED: 'true'
ELASTIC_GITHUB_STEP_COMMIT_STATUS_ENABLED: 'true'
GITHUB_BUILD_COMMIT_STATUS_CONTEXT: kibana-ci
GITHUB_STEP_COMMIT_STATUS_ENABLED: 'true'
allow_rebuilds: true
branch_configuration: ''
cancel_intermediate_builds: true
Expand Down
5 changes: 4 additions & 1 deletion .buildkite/pipeline-utils/test-failures/annotate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ export const annotateTestFailures = async () => {

buildkite.setAnnotation('test_failures', 'error', getAnnotation(failures, failureHtmlArtifacts));

if (process.env.PR_COMMENTS_ENABLED === 'true') {
if (
process.env.PR_COMMENTS_ENABLED === 'true' ||
process.env.ELASTIC_PR_COMMENTS_ENABLED === 'true'
) {
buildkite.setMetadata(
'pr_comment:test_failures:body',
getPrComment(failures, failureHtmlArtifacts)
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/lifecycle/post_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -euo pipefail
BUILD_SUCCESSFUL=$(ts-node "$(dirname "${0}")/build_status.ts")
export BUILD_SUCCESSFUL

if [[ "${GITHUB_BUILD_COMMIT_STATUS_ENABLED:-}" != "true" ]]; then
if [[ "${GITHUB_BUILD_COMMIT_STATUS_ENABLED:-}" != "true" ]] && [[ "${ELASTIC_GITHUB_BUILD_COMMIT_STATUS_ENABLED:-}" != "true" ]]; then
"$(dirname "${0}")/commit_status_complete.sh"
fi

Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/lifecycle/pre_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -euo pipefail

source .buildkite/scripts/common/util.sh

if [[ "${GITHUB_BUILD_COMMIT_STATUS_ENABLED:-}" != "true" ]]; then
if [[ "${GITHUB_BUILD_COMMIT_STATUS_ENABLED:-}" != "true" ]] && [[ "${ELASTIC_GITHUB_BUILD_COMMIT_STATUS_ENABLED:-}" != "true" ]]; then
"$(dirname "${0}")/commit_status_start.sh"
fi

Expand Down
20 changes: 19 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,7 @@ packages/presentation/presentation_containers @elastic/kibana-presentation
src/plugins/presentation_panel @elastic/kibana-presentation
packages/presentation/presentation_publishing @elastic/kibana-presentation
src/plugins/presentation_util @elastic/kibana-presentation
x-pack/packages/ai-infra/product-doc-artifact-builder @elastic/appex-ai-infra
x-pack/plugins/observability_solution/profiling_data_access @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/profiling @elastic/obs-ux-infra_services-team
packages/kbn-profiling-utils @elastic/obs-ux-infra_services-team
Expand Down Expand Up @@ -1308,6 +1309,10 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
/.devcontainer/ @elastic/kibana-operations

# Appex QA
/x-pack/test_serverless/functional/page_objects/svl_common_page.ts @elastic/appex-qa
/x-pack/test_serverless/README.md @elastic/appex-qa
/x-pack/test_serverless/api_integration/ftr_provider_context.d.ts @elastic/appex-qa
/x-pack/test_serverless/api_integration/test_suites/common/README.md @elastic/appex-qa
/src/dev/code_coverage @elastic/appex-qa
/test/functional/services/common @elastic/appex-qa
/test/functional/services/lib @elastic/appex-qa
Expand Down Expand Up @@ -1406,6 +1411,7 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
#CC# /x-pack/plugins/security/ @elastic/kibana-security

# Response Ops team
/x-pack/test_serverless/functional/test_suites/security/screenshot_creation/index.ts @elastic/response-ops
/x-pack/test/alerting_api_integration/ @elastic/response-ops
/x-pack/test/alerting_api_integration/observability @elastic/obs-ux-management-team
/x-pack/test/plugin_api_integration/test_suites/task_manager/ @elastic/response-ops
Expand Down Expand Up @@ -1438,11 +1444,16 @@ x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts @elastic/kib
/x-pack/test/functional/es_archives/alerting/8_2_0 @elastic/response-ops

# Enterprise Search
/x-pack/test_serverless/functional/page_objects/svl_ingest_pipelines.ts @elastic/search-kibana
/x-pack/test/functional/apps/dev_tools/embedded_console.ts @elastic/search-kibana
/x-pack/test/functional/apps/ingest_pipelines/feature_controls/ingest_pipelines_security.ts @elastic/search-kibana
/x-pack/test/functional/page_objects/embedded_console.ts @elastic/search-kibana
/x-pack/test/functional_enterprise_search/ @elastic/search-kibana
/x-pack/plugins/enterprise_search/public/applications/shared/doc_links @elastic/platform-docs
/x-pack/test_serverless/api_integration/test_suites/search/serverless_search @elastic/search-kibana
/x-pack/test_serverless/functional/test_suites/search/ @elastic/search-kibana
x-pack/test/api_integration/apis/management/index_management/inference_endpoints.ts @elastic/search-kibana
/x-pack/test_serverless/api_integration/test_suites/search @elastic/search-kibana

# Management Experience - Deployment Management
/x-pack/test_serverless/**/test_suites/common/index_management/ @elastic/kibana-management
Expand All @@ -1469,7 +1480,14 @@ x-pack/test/api_integration/apis/management/index_management/inference_endpoints
/x-pack/test/api_integration/apis/security_solution @elastic/security-solution
/x-pack/test/functional/es_archives/auditbeat/default @elastic/security-solution
/x-pack/test/functional/es_archives/auditbeat/hosts @elastic/security-solution

/x-pack/test_serverless/functional/page_objects/svl_management_page.ts @elastic/security-solution
/x-pack/test_serverless/api_integration/test_suites/common/platform_security/ @elastic/security-solution
/x-pack/test_serverless/api_integration/test_suites/security @elastic/security-solution
/x-pack/test_serverless/functional/page_objects/svl_sec_landing_page.ts @elastic/security-solution

/x-pack/test_serverless/functional/test_suites/security/cypress @elastic/security-solution
/x-pack/test_serverless/functional/test_suites/security/index.feature_flags.ts @elastic/security-solution
/x-pack/test_serverless/functional/test_suites/security/index.ts @elastic/security-solution
#CC# /x-pack/plugins/security_solution/ @elastic/security-solution

# Security Solution OpenAPI bundles
Expand Down
18 changes: 17 additions & 1 deletion docs/management/connectors/action-types/servicenow-sir.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,28 @@ The username for HTTP basic authentication.
You can test connectors as you're creating or editing the connector in {kib}. For example:

[role="screenshot"]
image::management/connectors/images/servicenow-sir-params-test.png[{sn-sir} params test]
image::management/connectors/images/servicenow-sir-params-test.png[{sn-sir} params test, width=75%]

{sn-sir} actions have the following configuration properties.

Additional comments::
Additional information for the client, such as how to troubleshoot the issue.
Additional fields::
An object that contains custom field identifiers and their values.
These fields must exist in the Elastic ServiceNow application and must be specified in JSON format.
+
--
For example:
[source,sh]
----
{
"u_cmdb_ci": "host-a",
"u_company": "My company",
"u_assignment_group": "Testing"
}
----
Note that the default source field names in the Elastic ServiceNow application are prefixed with "u_".
--
Category::
The category of the incident.
Correlation display::
Expand Down
23 changes: 21 additions & 2 deletions docs/management/connectors/action-types/servicenow.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,28 @@ The username for HTTP basic authentication.
When you create or edit a connector, use the *Test* tab to test its actions:

[role="screenshot"]
image::management/connectors/images/servicenow-params-test.png[ServiceNow params test]
image::management/connectors/images/servicenow-params-test.png[ServiceNow params test, width=75%]

{sn-itsm} actions have the following configuration properties.

Additional comments::
Additional information for the client, such as how to troubleshoot the issue.
Additional fields::
An object that contains custom field identifiers and their values.
+
--
These fields must exist in the Elastic ServiceNow application and must be specified in JSON format.
For example:
[source,sh]
----
{
"u_cmdb_ci": "host-a",
"u_company": "My company",
"u_assignment_group": "Testing"
}
----
Note that the default source field names in the Elastic ServiceNow application are prefixed with "u_".
--
Category::
The category of the incident.
Correlation display::
Expand All @@ -86,6 +102,9 @@ NOTE: Using the default configuration of `{{ruleID}}:{{alert ID}}` ensures that

Description::
The details about the incident.
Event action::
The type of action to test: resolve or trigger.
When you test a resolve action, you must provide a correlation identifier.
Impact::
The effect an incident has on business.
It can be measured by the number of affected users or by how critical it is to the business in question.
Expand All @@ -94,7 +113,7 @@ The severity of the incident.
Short description::
A short description for the incident, used for searching the contents of the knowledge base.
Subcategory::
The category of the incident.
The subcategory of the incident.
Urgency::
The extent to which the incident resolution can delay.

Expand Down
Binary file modified docs/management/connectors/images/servicenow-connector-basic.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/management/connectors/images/servicenow-params-test.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 26 additions & 4 deletions docs/upgrade-notes.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ ADD INSTRUCTIONS FOR USERS LOOKING TO UPGRADE. HOW CAN THEY WORK AROUND THIS?
====
1. Copy and edit the template in the right area section of this file. Most recent entries should be at the top of the section.
2. Edit the anchor ID [[REPO-PR]] of the template with proper values.
1. Copy and edit the template in the right section of this file. Most recent entries should be at the top of the section, search for sections using the text "[float]".
2. Edit the anchor ID [[REPO-PR]] of the template with proper values.
3. Don't hardcode the link to the new entry. Instead, make it available through the doc link service files:
- https://github.com/elastic/kibana/blob/main/packages/kbn-doc-links/src/get_doc_links.ts
- https://github.com/elastic/kibana/blob/main/packages/kbn-doc-links/src/types.ts
Expand All @@ -31,15 +31,15 @@ The entry in the main links file should look like this:
id: `${KIBANA_DOCS}breaking-changes-summary.html#REPO-PR`
Where:
- `id` is the ID of your choice.
- `id` is the ID of your choice.
- `REPO-PR` is the anchor ID that you assigned to the entry in this upgrade document.
4. You can then call the link from any Kibana code. For example: `href: docLinks.links.upgradeAssistant.id`
Check https://docs.elastic.dev/docs/kibana-doc-links (internal) for more details about the Doc links service.
////

Before you upgrade, review the breaking changes and deprecations introduced in {kib} 8.x, then mitigate the impact.
Before you upgrade, review the breaking changes and deprecations introduced in {kib} 8.x, then mitigate the impact.

For Elastic Security release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_].

Expand All @@ -49,6 +49,28 @@ For Elastic Security release information, refer to {security-guide}/release-note
[float]
==== Kibana APIs

[discrete]
[[breaking-193792]]
.Access to all internal APIs is blocked (9.0.0)
[%collapsible]
====
*Details* +
Access to internal Kibana HTTP APIs is restricted from version 9.0.0. This is to ensure
that HTTP API integrations with Kibana avoid unexpected breaking changes.
Refer to {kibana-pull}193792[#193792].
*Impact* +
Any HTTP API calls to internal Kibana endpoints will fail with a 400 status code starting
from version 9.0.0.
*Action* +
**Do not integrate with internal HTTP APIs**. They may change or be removed without notice,
and lead to unexpected behaviors. If you would like some capability to be exposed over an
HTTP API, https://github.com/elastic/kibana/issues/new/choose[create an issue].
We would love to discuss your use case.
====

[discrete]
[[breaking-162506]]
.Get case metrics APIs became internal. (8.10)
Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit d5d9eb0

Please sign in to comment.