Rename "Endpoints" to "Connection details"

elastic · Nov 27, 2023 · d55f1d6 · d55f1d6
1 parent 0942bce
commit d55f1d6
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 20 deletions.
diff --git a/docs/setup/connect-to-elasticsearch.asciidoc b/docs/setup/connect-to-elasticsearch.asciidoc
@@ -54,9 +54,9 @@ Details for each programming language library that Elastic provides are in the
 https://www.elastic.co/guide/en/elasticsearch/client/index.html[{es} Client documentation].
 
 If you are running {kib} on our hosted {es} Service,
-click *Endpoints* on the *Integrations* view
+click *Connection details* on the *Integrations* view
 to verify your {es} endpoint and Cloud ID, and create API keys for integration.
-Alternatively, the *Endpoints* are also accessible through the top bar help menu.
+Alternatively, the *Connection details* are also accessible through the top bar help menu.
 
 [float]
 === Add sample data

diff --git a/packages/cloud/deployment_details/deployment_details_modal.tsx b/packages/cloud/deployment_details/deployment_details_modal.tsx
@@ -38,8 +38,8 @@ export const DeploymentDetailsModal: FC<Props> = ({ closeModal }) => {
     >
       <EuiModalHeader>
         <EuiModalHeaderTitle>
-          {i18n.translate('cloud.deploymentDetails.helpMenuLinks.endpoints', {
-            defaultMessage: 'Endpoints',
+          {i18n.translate('cloud.deploymentDetails.helpMenuLinks.connectionDetails', {
+            defaultMessage: 'Connection details',
           })}
         </EuiModalHeaderTitle>
       </EuiModalHeader>

diff --git a/...maybe_add_cloud_links/endpoints_modal.tsx → ..._cloud_links/connection_details_modal.tsx b/...maybe_add_cloud_links/endpoints_modal.tsx → ..._cloud_links/connection_details_modal.tsx
@@ -22,7 +22,7 @@ interface Props {
   share: SharePluginStart;
 }
 
-export const EndpointsModal = ({ core, share, cloud, docLinks, closeModal }: Props) => {
+export const ConnectionDetailsModal = ({ core, share, cloud, docLinks, closeModal }: Props) => {
   return (
     <DeploymentDetailsKibanaProvider core={core} share={share} cloud={cloud} docLinks={docLinks}>
       <DeploymentDetailsModal closeModal={closeModal} />

diff --git a/...k/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/help_menu_links.tsx b/...k/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/help_menu_links.tsx
@@ -13,7 +13,7 @@ import type { CloudStart } from '@kbn/cloud-plugin/public';
 import type { SharePluginStart } from '@kbn/share-plugin/public';
 import { toMountPoint } from '@kbn/react-kibana-mount';
 
-import { EndpointsModal } from './endpoints_modal';
+import { ConnectionDetailsModal } from './connection_details_modal';
 
 export const createHelpMenuLinks = ({
   docLinks,
@@ -50,15 +50,15 @@ export const createHelpMenuLinks = ({
       href: docLinks.links.kibana.feedback,
     },
     {
-      title: i18n.translate('xpack.cloudLinks.helpMenuLinks.endpoints', {
-        defaultMessage: 'Endpoints',
+      title: i18n.translate('xpack.cloudLinks.helpMenuLinks.connectionDetails', {
+        defaultMessage: 'Connection details',
       }),
       iconType: 'console',
-      dataTestSubj: 'endpointsHelpLink',
+      dataTestSubj: 'connectionDetailsHelpLink',
       onClick: () => {
         const modal = overlays.openModal(
           toMountPoint(
-            <EndpointsModal
+            <ConnectionDetailsModal
               core={core}
               share={share}
               cloud={cloud}

diff --git a/...cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.test.ts b/...cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.test.ts
@@ -94,10 +94,10 @@ describe('maybeAddCloudLinks', () => {
             "title": "Give feedback",
           },
           Object {
-            "dataTestSubj": "endpointsHelpLink",
+            "dataTestSubj": "connectionDetailsHelpLink",
             "iconType": "console",
             "onClick": [Function],
-            "title": "Endpoints",
+            "title": "Connection details",
           },
         ],
       ]
@@ -168,10 +168,10 @@ describe('maybeAddCloudLinks', () => {
             "title": "Give feedback",
           },
           Object {
-            "dataTestSubj": "endpointsHelpLink",
+            "dataTestSubj": "connectionDetailsHelpLink",
             "iconType": "console",
             "onClick": [Function],
-            "title": "Endpoints",
+            "title": "Connection details",
           },
         ],
       ]

diff --git a/...k/plugins/fleet/public/applications/integrations/components/header/deployment_details.tsx b/...k/plugins/fleet/public/applications/integrations/components/header/deployment_details.tsx
@@ -32,9 +32,9 @@ export const DeploymentDetails = () => {
   }
 
   const button = (
-    <EuiHeaderLink onClick={() => setIsOpen(!isOpen)} iconType="iInCircle" iconSide="left" isActive>
-      {i18n.translate('xpack.fleet.integrations.endpointsButton', {
-        defaultMessage: 'Endpoints',
+    <EuiHeaderLink onClick={() => setIsOpen(!isOpen)} isActive>
+      {i18n.translate('xpack.fleet.integrations.connectionDetailsButton', {
+        defaultMessage: 'Connection details',
       })}
     </EuiHeaderLink>
   );

diff --git a/x-pack/test/functional_cloud/tests/cloud_links.ts b/x-pack/test/functional_cloud/tests/cloud_links.ts
@@ -48,11 +48,16 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
 
       it('A button to open a modal to view the CloudID and ES endpoint is added', async () => {
-        await PageObjects.common.clickAndValidate('helpMenuButton', 'endpointsHelpLink');
-        expect(await find.byCssSelector('[data-test-subj="endpointsHelpLink"]')).to.not.be(null);
+        await PageObjects.common.clickAndValidate('helpMenuButton', 'connectionDetailsHelpLink');
+        expect(await find.byCssSelector('[data-test-subj="connectionDetailsHelpLink"]')).to.not.be(
+          null
+        );
 
         // Open the modal
-        await PageObjects.common.clickAndValidate('endpointsHelpLink', 'deploymentDetailsModal');
+        await PageObjects.common.clickAndValidate(
+          'connectionDetailsHelpLink',
+          'deploymentDetailsModal'
+        );
 
         const esEndpointInput = await find.byCssSelector(
           '[data-test-subj="deploymentDetailsEsEndpoint"]'