[Fleet] Fix agent policy space validation

elastic · Nov 14, 2024 · d53aea4 · d53aea4
1 parent bb68f92
commit d53aea4
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 4 deletions.
diff --git a/...pplications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/index.tsx b/...pplications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/index.tsx
@@ -375,8 +375,8 @@ export const AgentPolicyAdvancedOptionsContent: React.FunctionComponent<Props> =
       >
         <EuiFormRow
           fullWidth
-          error={touchedFields.namespace && validation.namespace ? validation.namespace : null}
-          isInvalid={Boolean(touchedFields.namespace && validation.namespace)}
+          error={validation.namespace ? validation.namespace : null}
+          isInvalid={Boolean(validation.namespace)}
           isDisabled={disabled}
         >
           <EuiComboBox

diff --git a/x-pack/plugins/fleet/server/services/spaces/space_settings.test.ts b/x-pack/plugins/fleet/server/services/spaces/space_settings.test.ts
@@ -10,7 +10,7 @@ import { SavedObjectsErrorHelpers } from '@kbn/core-saved-objects-server';
 
 import { appContextService } from '../app_context';
 
-import { saveSpaceSettings } from './space_settings';
+import { getSpaceSettings, saveSpaceSettings } from './space_settings';
 
 jest.mock('../app_context');
 
@@ -102,3 +102,35 @@ describe('saveSpaceSettings', () => {
     });
   });
 });
+
+describe('getSpaceSettings', () => {
+  function createSavedsClientMock(settingsAttributes?: any) {
+    const client = savedObjectsClientMock.create();
+
+    if (settingsAttributes) {
+      client.get.mockResolvedValue({
+        attributes: settingsAttributes,
+      } as any);
+    } else {
+      client.get.mockRejectedValue(
+        SavedObjectsErrorHelpers.createGenericNotFoundError('Not found')
+      );
+    }
+
+    jest.mocked(appContextService.getInternalUserSOClientForSpaceId).mockReturnValue(client);
+
+    return client;
+  }
+  it('should work with managedBy:null', async () => {
+    createSavedsClientMock({
+      allowed_namespace_prefixes: ['test'],
+      managed_by: null,
+    });
+    const res = await getSpaceSettings();
+
+    expect(res).toEqual({
+      allowed_namespace_prefixes: ['test'],
+      managed_by: undefined,
+    });
+  });
+});
diff --git a/x-pack/plugins/fleet/server/services/spaces/space_settings.ts b/x-pack/plugins/fleet/server/services/spaces/space_settings.ts
@@ -36,7 +36,7 @@ export async function getSpaceSettings(spaceId?: string) {
 
   return {
     allowed_namespace_prefixes: settings?.attributes?.allowed_namespace_prefixes ?? [],
-    managed_by: settings?.attributes?.managed_by,
+    managed_by: settings?.attributes?.managed_by ?? undefined,
   };
 }