Skip to content

Commit

Permalink
[8.17] Revert "[dashboard] fix Reset dashboard breaks panel stat…
Browse files Browse the repository at this point in the history
…e when ran after editor edits (#201687)" (#201902) (#202019)

# Backport

This will backport the following commits from `main` to `8.17`:
- [Revert "[dashboard] fix Reset dashboard breaks panel state when
ran after editor edits (#201687)"
(#201902)](#201902)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T04:53:22Z","message":"Revert
\"[dashboard] fix Reset dashboard breaks panel state when ran after
editor edits (#201687)\" (#201902)\n\nThis reverts commit
289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","backport:version","v8.17.0","v8.16.2"],"title":"Revert
\"[dashboard] fix Reset dashboard breaks panel state when ran after
editor edits
(#201687)\"","number":201902,"url":"https://github.com/elastic/kibana/pull/201902","mergeCommit":{"message":"Revert
\"[dashboard] fix Reset dashboard breaks panel state when ran after
editor edits (#201687)\" (#201902)\n\nThis reverts commit
289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201902","number":201902,"mergeCommit":{"message":"Revert
\"[dashboard] fix Reset dashboard breaks panel state when ran after
editor edits (#201687)\" (#201902)\n\nThis reverts commit
289bb16.","sha":"a0f88d90134f8c49b32cffe23f438a91f77c7055"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
  • Loading branch information
kibanamachine and jbudz authored Nov 27, 2024
1 parent 0be9fe9 commit d3094b7
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ export const initializeDashboard = async ({
hidePanelTitles: panelToUpdate.explicitInput.hidePanelTitles,
};
if (embeddableService.reactEmbeddableRegistryHasKey(incomingEmbeddable.type)) {
panelToUpdate.explicitInput = { id: panelToUpdate.explicitInput.id };
runtimePanelsToRestore[incomingEmbeddable.embeddableId] = nextRuntimeState;
} else {
panelToUpdate.explicitInput = nextRuntimeState;
Expand Down

0 comments on commit d3094b7

Please sign in to comment.