[8.x] Remove unused`kbn-ace` code (#195353) (#195727)

# Backport This will backport the following commits from `main` to `8.x`: - [Remove unused`kbn-ace` code (#195353)](#195353)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Ignacio Rivas <[email protected]>
elastic · Oct 10, 2024 · cbef50e · cbef50e
1 parent 950e073
commit cbef50e
Show file tree

Hide file tree

Showing 14 changed files with 5 additions and 40 deletions.
diff --git a/x-pack/plugins/data_visualizer/kibana.jsonc b/x-pack/plugins/data_visualizer/kibana.jsonc
@@ -33,7 +33,6 @@
       "kibanaReact",
       "kibanaUtils",
       "maps",
-      "esUiShared",
       "fieldFormats",
       "uiActions",
       "lens",

diff --git a/...visualizer/public/application/file_data_visualizer/components/json_editor/json_editor.tsx b/...visualizer/public/application/file_data_visualizer/components/json_editor/json_editor.tsx
@@ -9,9 +9,8 @@ import type { FC } from 'react';
 import React from 'react';
 
 import { CodeEditor, type CodeEditorProps } from '@kbn/code-editor';
-import { expandLiteralStrings, XJsonMode } from '../../../shared_imports';
 
-export const EDITOR_MODE = { TEXT: 'text', JSON: 'json', XJSON: new XJsonMode() };
+export const EDITOR_MODE = { TEXT: 'text', JSON: 'json' };
 
 interface JobEditorProps {
   value: string;
@@ -30,10 +29,6 @@ export const JsonEditor: FC<JobEditorProps> = ({
   readOnly = false,
   onChange = () => {},
 }) => {
-  if (mode === EDITOR_MODE.XJSON) {
-    value = expandLiteralStrings(value);
-  }
-
   return (
     <CodeEditor
       value={value}

diff --git a/x-pack/plugins/data_visualizer/public/application/shared_imports.ts b/x-pack/plugins/data_visualizer/public/application/shared_imports.ts
diff --git a/x-pack/plugins/data_visualizer/tsconfig.json b/x-pack/plugins/data_visualizer/tsconfig.json
@@ -12,7 +12,6 @@
     "types/**/*"
   ],
   "kbn_references": [
-    "@kbn/ace",
     "@kbn/aiops-components",
     "@kbn/charts-plugin",
     "@kbn/cloud-plugin",
@@ -32,7 +31,6 @@
     "@kbn/embeddable-plugin",
     "@kbn/es-query",
     "@kbn/es-types",
-    "@kbn/es-ui-shared-plugin",
     "@kbn/esql-utils",
     "@kbn/field-formats-plugin",
     "@kbn/field-types",

diff --git a/...frame_analytics/pages/analytics_creation/components/runtime_mappings/runtime_mappings.tsx b/...frame_analytics/pages/analytics_creation/components/runtime_mappings/runtime_mappings.tsx
@@ -20,7 +20,6 @@ import {
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
-import { XJsonMode } from '@kbn/ace';
 import { XJson } from '@kbn/es-ui-shared-plugin/public';
 import { isPopulatedObject } from '@kbn/ml-is-populated-object';
 import { getCombinedRuntimeMappings, isRuntimeMappings } from '@kbn/ml-runtime-field-utils';
@@ -66,8 +65,6 @@ const RUNTIME_FIELDS_LABEL_TEXT = i18n.translate(
 );
 
 const { useXJsonMode } = XJson;
-const xJsonMode = new XJsonMode();
-export type XJsonModeType = ReturnType<typeof XJsonMode>;
 
 interface Props {
   actions: CreateAnalyticsFormProps['actions'];
@@ -176,7 +173,6 @@ export const RuntimeMappings: FC<Props> = ({ actions, state }) => {
                   }
                   setAdvancedRuntimeMappingsConfig={setAdvancedRuntimeMappingsConfig}
                   convertToJson={convertToJson}
-                  xJsonMode={xJsonMode}
                 />
               </>
             )}

diff --git a/...nalytics/pages/analytics_creation/components/runtime_mappings/runtime_mappings_editor.tsx b/...nalytics/pages/analytics_creation/components/runtime_mappings/runtime_mappings_editor.tsx
@@ -12,21 +12,18 @@ import { i18n } from '@kbn/i18n';
 
 import { CodeEditor } from '@kbn/code-editor';
 import { isRuntimeMappings } from '@kbn/ml-runtime-field-utils';
-import type { XJsonModeType } from './runtime_mappings';
 
 interface Props {
   convertToJson: (data: string) => string;
   setAdvancedRuntimeMappingsConfig: React.Dispatch<string>;
   setIsRuntimeMappingsEditorApplyButtonEnabled: React.Dispatch<React.SetStateAction<boolean>>;
   advancedEditorRuntimeMappingsLastApplied: string | undefined;
   advancedRuntimeMappingsConfig: string;
-  xJsonMode: XJsonModeType;
 }
 
 export const RuntimeMappingsEditor: FC<Props> = memo(
   ({
     convertToJson,
-    xJsonMode,
     setAdvancedRuntimeMappingsConfig,
     setIsRuntimeMappingsEditorApplyButtonEnabled,
     advancedEditorRuntimeMappingsLastApplied,

diff --git a/...ication/jobs/new_job/pages/components/common/datafeed_preview_flyout/datafeed_preview.tsx b/...ication/jobs/new_job/pages/components/common/datafeed_preview_flyout/datafeed_preview.tsx
@@ -29,7 +29,7 @@ export const DatafeedPreview: FC<{
   const {
     jobs: { datafeedPreview },
   } = useMlApi();
-  // the ace editor requires a fixed height
+  // the editor requires a fixed height
   const editorHeight = useMemo(
     () => `${window.innerHeight - 230 - heightOffset}px`,
     [heightOffset]

diff --git a/...pplication/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx b/...pplication/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx
@@ -298,7 +298,7 @@ const Contents: FC<{
   heightOffset?: number;
   schema?: object;
 }> = ({ title, value, editJson, onChange, heightOffset = 0, schema }) => {
-  // the ace editor requires a fixed height
+  // the editor requires a fixed height
   const editorHeight = useMemo(
     () => `${window.innerHeight - 230 - heightOffset}px`,
     [heightOffset]

diff --git a/x-pack/plugins/ml/tsconfig.json b/x-pack/plugins/ml/tsconfig.json
@@ -24,7 +24,6 @@
       "path": "../../../src/setup_node_env/tsconfig.json"
     },
     // add references to other TypeScript projects the plugin depends on
-    "@kbn/ace",
     "@kbn/actions-plugin",
     "@kbn/aiops-plugin",
     "@kbn/alerting-plugin",

diff --git a/.../app/sections/create_transform/components/advanced_pivot_editor/advanced_pivot_editor.tsx b/.../app/sections/create_transform/components/advanced_pivot_editor/advanced_pivot_editor.tsx
@@ -18,7 +18,7 @@ import type { StepDefineFormHook } from '../step_define';
 export const AdvancedPivotEditor: FC<StepDefineFormHook['advancedPivotEditor']> = memo(
   ({
     actions: { convertToJson, setAdvancedEditorConfig, setAdvancedPivotEditorApplyButtonEnabled },
-    state: { advancedEditorConfigLastApplied, advancedEditorConfig, xJsonMode },
+    state: { advancedEditorConfigLastApplied, advancedEditorConfig },
   }) => {
     return (
       <EuiFormRow

diff --git a/...ransform/components/advanced_runtime_mappings_editor/advanced_runtime_mappings_editor.tsx b/...ransform/components/advanced_runtime_mappings_editor/advanced_runtime_mappings_editor.tsx
@@ -23,7 +23,7 @@ export const AdvancedRuntimeMappingsEditor: FC<StepDefineFormHook['runtimeMappin
       setAdvancedRuntimeMappingsConfig,
       setRuntimeMappingsEditorApplyButtonEnabled,
     },
-    state: { advancedEditorRuntimeMappingsLastApplied, advancedRuntimeMappingsConfig, xJsonMode },
+    state: { advancedEditorRuntimeMappingsLastApplied, advancedRuntimeMappingsConfig },
   }) => {
     return (
       <div data-test-subj="transformAdvancedRuntimeMappingsEditor">

diff --git a/...c/app/sections/create_transform/components/step_define/hooks/use_advanced_pivot_editor.ts b/...c/app/sections/create_transform/components/step_define/hooks/use_advanced_pivot_editor.ts
@@ -6,7 +6,6 @@
  */
 
 import { useEffect, useState } from 'react';
-import { XJsonMode } from '@kbn/ace';
 
 import { XJson } from '@kbn/es-ui-shared-plugin/public';
 
@@ -15,7 +14,6 @@ import type { PostTransformsPreviewRequestSchema } from '../../../../../../../se
 import type { StepDefineExposedState } from '../common';
 
 const { useXJsonMode } = XJson;
-const xJsonMode = new XJsonMode();
 
 export const useAdvancedPivotEditor = (
   defaults: StepDefineExposedState,
@@ -71,7 +69,6 @@ export const useAdvancedPivotEditor = (
       isAdvancedEditorSwitchModalVisible,
       isAdvancedPivotEditorApplyButtonEnabled,
       isAdvancedPivotEditorEnabled,
-      xJsonMode,
     },
   };
 };
diff --git a/...ons/create_transform/components/step_define/hooks/use_advanced_runtime_mappings_editor.ts b/...ons/create_transform/components/step_define/hooks/use_advanced_runtime_mappings_editor.ts
@@ -6,12 +6,10 @@
  */
 
 import { useState } from 'react';
-import { XJsonMode } from '@kbn/ace';
 import { XJson } from '@kbn/es-ui-shared-plugin/public';
 import type { StepDefineExposedState } from '../common';
 
 const { useXJsonMode } = XJson;
-const xJsonMode = new XJsonMode();
 
 export const useAdvancedRuntimeMappingsEditor = (defaults: StepDefineExposedState) => {
   const stringifiedRuntimeMappings = JSON.stringify(defaults.runtimeMappings, null, 2);
@@ -81,7 +79,6 @@ export const useAdvancedRuntimeMappingsEditor = (defaults: StepDefineExposedStat
       isRuntimeMappingsEditorSwitchModalVisible,
       runtimeMappingsUpdated,
       advancedRuntimeMappingsConfig,
-      xJsonMode,
       runtimeMappings,
     },
   };

diff --git a/x-pack/plugins/transform/tsconfig.json b/x-pack/plugins/transform/tsconfig.json
@@ -30,7 +30,6 @@
     "@kbn/triggers-actions-ui-plugin",
     "@kbn/i18n-react",
     "@kbn/kibana-react-plugin",
-    "@kbn/ace",
     "@kbn/es-ui-shared-plugin",
     "@kbn/discover-plugin",
     "@kbn/kibana-utils-plugin",