variable naming update

elastic · Sep 27, 2024 · c65579c · c65579c
1 parent 4bafe20
commit c65579c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/...s/ml/public/application/timeseriesexplorer/components/series_controls/series_controls.tsx b/...s/ml/public/application/timeseriesexplorer/components/series_controls/series_controls.tsx
@@ -142,7 +142,7 @@ export const SeriesControls: FC<PropsWithChildren<SeriesControlsProps>> = ({
 
   // Merge the default config with the one from the local storage
   const resultFieldsConfig = useMemo(() => {
-    const defaultFieldConfig = getDefaultFieldConfig(
+    const resultFieldConfig = getDefaultFieldConfig(
       entityControls,
       !storageFieldsConfig
         ? true
@@ -153,17 +153,17 @@ export const SeriesControls: FC<PropsWithChildren<SeriesControlsProps>> = ({
     );
 
     // Early return to prevent unnecessary looping through the default config
-    if (!storageFieldsConfig) return defaultFieldConfig;
+    if (!storageFieldsConfig) return resultFieldConfig;
 
     // Override only the fields properties stored in the local storage
-    for (const key of Object.keys(defaultFieldConfig) as MlEntityFieldType[]) {
-      defaultFieldConfig[key] = {
-        ...defaultFieldConfig[key],
+    for (const key of Object.keys(resultFieldConfig) as MlEntityFieldType[]) {
+      resultFieldConfig[key] = {
+        ...resultFieldConfig[key],
         ...storageFieldsConfig[key],
       } as UiPartitionFieldConfig;
     }
 
-    return defaultFieldConfig;
+    return resultFieldConfig;
   }, [entityControls, storageFieldsConfig]);
 
   /**

diff --git a/x-pack/plugins/ml/server/models/results_service/get_partition_fields_values.ts b/x-pack/plugins/ml/server/models/results_service/get_partition_fields_values.ts
@@ -46,7 +46,7 @@ function getFieldAgg(
   const sortByField =
     fieldConfig?.sort?.by === 'name' || isModelPlotSearch ? '_key' : 'maxRecordScore';
 
-  const filterValues = Object.entries(fieldsConfig ?? {})
+  const splitFieldFilterValues = Object.entries(fieldsConfig ?? {})
     .filter(([key, field]) => key !== fieldType && field.value)
     .map(([key, field]) => ({
       fieldValueKey: `${key}_value`,
@@ -85,9 +85,9 @@ function getFieldAgg(
                   },
                 ]
               : []),
-            ...filterValues.map((filter) => ({
+            ...splitFieldFilterValues.map((filterValue) => ({
               term: {
-                [filter.fieldValueKey]: filter.fieldValue,
+                [filterValue.fieldValueKey]: filterValue.fieldValue,
               },
             })),
           ],