Overwrite the transform document _id from the rollup pipeline to ensu…

…re uniqness
elastic · Oct 31, 2024 · b6fa512 · b6fa512
1 parent 0cd2d92
commit b6fa512
Show file tree

Hide file tree

Showing 7 changed files with 217 additions and 164 deletions.
diff --git a/...lugins/observability_solution/slo/server/assets/ingest_templates/slo_pipeline_template.ts b/...lugins/observability_solution/slo/server/assets/ingest_templates/slo_pipeline_template.ts
@@ -17,6 +17,12 @@ export const getSLOPipelineTemplate = (slo: SLODefinition) => ({
   id: getSLOPipelineId(slo.id, slo.revision),
   description: `Ingest pipeline for SLO rollup data [id: ${slo.id}, revision: ${slo.revision}]`,
   processors: [
+    {
+      set: {
+        field: '_id',
+        value: `${slo.id}-${slo.revision}-{{{_id}}}`,
+      },
+    },
     {
       set: {
         field: 'event.ingested',

diff --git a/.../plugins/observability_solution/slo/server/services/__snapshots__/create_slo.test.ts.snap b/.../plugins/observability_solution/slo/server/services/__snapshots__/create_slo.test.ts.snap
diff --git a/...k/plugins/observability_solution/slo/server/services/__snapshots__/reset_slo.test.ts.snap b/...k/plugins/observability_solution/slo/server/services/__snapshots__/reset_slo.test.ts.snap
diff --git a/...o/server/services/transform_generators/__snapshots__/synthetics_availability.test.ts.snap b/...o/server/services/transform_generators/__snapshots__/synthetics_availability.test.ts.snap
diff --git a/...n/slo/server/services/transform_generators/__snapshots__/transform_generator.test.ts.snap b/...n/slo/server/services/transform_generators/__snapshots__/transform_generator.test.ts.snap
diff --git a/...ability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts b/...ability_solution/slo/server/services/transform_generators/synthetics_availability.test.ts
@@ -5,13 +5,12 @@
  * 2.0.
  */
 
-import { ALL_VALUE } from '@kbn/slo-schema';
 import { dataViewsService } from '@kbn/data-views-plugin/server/mocks';
+import { ALL_VALUE } from '@kbn/slo-schema';
 import { SLODefinition } from '../../domain/models';
+import { twoMinute } from '../fixtures/duration';
 import { createSLO, createSyntheticsAvailabilityIndicator } from '../fixtures/slo';
 import { SyntheticsAvailabilityTransformGenerator } from './synthetics_availability';
-import { SYNTHETICS_INDEX_PATTERN } from '../../../common/constants';
-import { twoMinute } from '../fixtures/duration';
 
 const generator = new SyntheticsAvailabilityTransformGenerator();
 
@@ -22,119 +21,7 @@ describe('Synthetics Availability Transform Generator', () => {
     const slo = createSLO({ id: 'irrelevant', indicator: createSyntheticsAvailabilityIndicator() });
     const transform = await generator.getTransformParams(slo, spaceId, dataViewsService);
 
-    expect(transform).toEqual({
-      _meta: {
-        managed: true,
-        managed_by: 'observability',
-        version: 3.3,
-      },
-      defer_validation: true,
-      description: 'Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]',
-      dest: {
-        index: '.slo-observability.sli-v3.3',
-        pipeline: '.slo-observability.sli.pipeline-irrelevant-1',
-      },
-      frequency: '1m',
-      pivot: {
-        aggregations: {
-          'slo.denominator': {
-            filter: {
-              term: {
-                'summary.final_attempt': true,
-              },
-            },
-          },
-          'slo.numerator': {
-            filter: {
-              term: {
-                'monitor.status': 'up',
-              },
-            },
-          },
-        },
-        group_by: {
-          '@timestamp': {
-            date_histogram: {
-              field: '@timestamp',
-              fixed_interval: '1m',
-            },
-          },
-          'monitor.config_id': {
-            terms: {
-              field: 'config_id',
-            },
-          },
-          'monitor.name': {
-            terms: {
-              field: 'monitor.name',
-            },
-          },
-          'observer.name': {
-            terms: {
-              field: 'observer.name',
-            },
-          },
-          'observer.geo.name': {
-            terms: {
-              field: 'observer.geo.name',
-            },
-          },
-          'slo.groupings.monitor.name': {
-            terms: {
-              field: 'monitor.name',
-            },
-          },
-          'slo.groupings.observer.geo.name': {
-            terms: {
-              field: 'observer.geo.name',
-            },
-          },
-          'slo.groupings.monitor.id': {
-            terms: {
-              field: 'monitor.id',
-            },
-          },
-        },
-      },
-      settings: {
-        deduce_mappings: false,
-        unattended: true,
-      },
-      source: {
-        index: SYNTHETICS_INDEX_PATTERN,
-        query: {
-          bool: {
-            filter: [
-              {
-                term: {
-                  'summary.final_attempt': true,
-                },
-              },
-              {
-                term: {
-                  'meta.space_id': 'custom-space',
-                },
-              },
-              {
-                range: {
-                  '@timestamp': {
-                    gte: 'now-7d/d',
-                  },
-                },
-              },
-            ],
-          },
-        },
-        runtime_mappings: {},
-      },
-      sync: {
-        time: {
-          delay: '1m',
-          field: 'event.ingested',
-        },
-      },
-      transform_id: 'slo-irrelevant-1',
-    });
+    expect(transform).toMatchSnapshot();
     expect(transform.source.query?.bool?.filter).toContainEqual({
       term: {
         'summary.final_attempt': true,