Fix bad merge

elastic · Oct 25, 2023 · b16baec · b16baec
1 parent 8761805
commit b16baec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...gers_actions_ui/public/application/components/rules_setting/rules_settings_modal.test.tsx b/...gers_actions_ui/public/application/components/rules_setting/rules_settings_modal.test.tsx
@@ -162,8 +162,9 @@ describe('rules_settings_modal', () => {
   test('reset flapping settings to initial state on cancel without triggering another server reload', async () => {
     const result = render(<RulesSettingsModalWithProviders {...modalProps} />);
     expect(getFlappingSettingsMock).toHaveBeenCalledTimes(1);
-    expect(getQueryDelaySettingsMock).toHaveBeenCalledTimes(1);
-    await waitForModalLoad();
+    await waitFor(() => {
+      expect(result.queryByTestId('centerJustifiedSpinner')).toBe(null);
+    });
 
     const lookBackWindowInput = result.getByTestId('lookBackWindowRangeInput');
     const statusChangeThresholdInput = result.getByTestId('statusChangeThresholdRangeInput');
@@ -181,12 +182,11 @@ describe('rules_settings_modal', () => {
     expect(updateFlappingSettingsMock).not.toHaveBeenCalled();
     expect(modalProps.onSave).not.toHaveBeenCalled();
 
-    expect(screen.queryByTestId('centerJustifiedSpinner')).toBe(null);
+    expect(result.queryByTestId('centerJustifiedSpinner')).toBe(null);
     expect(lookBackWindowInput.getAttribute('value')).toBe('10');
     expect(statusChangeThresholdInput.getAttribute('value')).toBe('10');
 
     expect(getFlappingSettingsMock).toHaveBeenCalledTimes(1);
-    expect(getQueryDelaySettingsMock).toHaveBeenCalledTimes(1);
   });
 
   test('should prevent statusChangeThreshold from being greater than lookBackWindow', async () => {

diff --git a/.../triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx b/.../triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx
@@ -246,7 +246,7 @@ export const RulesSettingsModal = memo((props: RulesSettingsModalProps) => {
 
   const handleSave = () => {
     if (canWriteFlappingSettings && hasFlappingChanged) {
-      mutate(flappingSettings);
+      mutate(flappingSettings!);
       setFlappingSettings(flappingSettings!, true);
     }
   };