Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
# Backport Manual backport due to merge conflicts. This will backport the following commits from `main` to `7.17`: - [Remove CI Composite Storybook (#171258)](#171258) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brad White","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-21T21:59:39Z","message":"Remove CI Composite Storybook (#171258)\n\n## Summary\r\nCloses #160803\r\n\r\nThis PR removes the `CI Composite` story because it has been broken\r\nsince at least ac23dce (and possibly\r\nsince b862a6c). The functionality is\r\ncovered by the generated `index.html` in\r\nhttps://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120\r\n\r\nTo fix the composite story requires generating `stories.json` for every\r\nstorybook, which requires migrating the repo off the deprecated\r\n`storiesOf` API. That task is quite extensive and would be better\r\nhandled alongside an upgrade to Storybook 7.x","sha":"1919c87b90c4f489c2027d71293631d89034f40f","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","ci:build-storybooks","v8.12.0"],"number":171258,"url":"https://github.com/elastic/kibana/pull/171258","mergeCommit":{"message":"Remove CI Composite Storybook (#171258)\n\n## Summary\r\nCloses #160803\r\n\r\nThis PR removes the `CI Composite` story because it has been broken\r\nsince at least ac23dce (and possibly\r\nsince b862a6c). The functionality is\r\ncovered by the generated `index.html` in\r\nhttps://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120\r\n\r\nTo fix the composite story requires generating `stories.json` for every\r\nstorybook, which requires migrating the repo off the deprecated\r\n`storiesOf` API. That task is quite extensive and would be better\r\nhandled alongside an upgrade to Storybook 7.x","sha":"1919c87b90c4f489c2027d71293631d89034f40f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171258","number":171258,"mergeCommit":{"message":"Remove CI Composite Storybook (#171258)\n\n## Summary\r\nCloses #160803\r\n\r\nThis PR removes the `CI Composite` story because it has been broken\r\nsince at least ac23dce (and possibly\r\nsince b862a6c). The functionality is\r\ncovered by the generated `index.html` in\r\nhttps://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120\r\n\r\nTo fix the composite story requires generating `stories.json` for every\r\nstorybook, which requires migrating the repo off the deprecated\r\n`storiesOf` API. That task is quite extensive and would be better\r\nhandled alongside an upgrade to Storybook 7.x","sha":"1919c87b90c4f489c2027d71293631d89034f40f"}},{"url":"https://github.com/elastic/kibana/pull/171695","number":171695,"branch":"8.11","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
- Loading branch information