Skip to content

Commit

Permalink
[Onboarding][Firehose] Add flag to skip AWS assets installation (#196325
Browse files Browse the repository at this point in the history
)

Closes #193857
Resolves #193294

Turns out, dockerized registry is [already being
used](https://buildkite.com/elastic/kibana-on-merge/builds/51727#01926d5a-f424-4b8e-b835-0f731c6ddc8d/264-454)
for Firehose tests and it's still failing sometimes. So this change adds
an explicit flag to skip installation of AWS assets as they are not
essential to complete the flow, only the Firehose integration is
required.

[Flaky test runner
job](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7167).
  • Loading branch information
mykolaharmash authored Oct 18, 2024
1 parent 7178062 commit ad53fcd
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ const createFirehoseOnboardingFlowRoute = createObservabilityOnboardingServerRou
request,
plugins,
services,
logger,
}): Promise<CreateFirehoseOnboardingFlowRouteResponse> {
const {
elasticsearch: { client },
} = await context.core;

const hasPrivileges = await hasLogMonitoringPrivileges(client.asCurrentUser);

if (!hasPrivileges) {
Expand All @@ -61,9 +61,19 @@ const createFirehoseOnboardingFlowRoute = createObservabilityOnboardingServerRou
const [{ encoded: apiKeyEncoded }] = await Promise.all([
createShipperApiKey(client.asCurrentUser, 'firehose_onboarding'),
packageClient.ensureInstalledPackage({ pkgName: 'awsfirehose' }),
packageClient.ensureInstalledPackage({ pkgName: 'aws' }),
]);

/**
* Triggering the AWS package installation but not
* waiting for the completion as it might take a while.
* The AWS integration is not required for data ingestion
* and can be installed separately in case it fails to install
* during onboarding.
*/
packageClient.ensureInstalledPackage({ pkgName: 'aws' }).catch((error) => {
logger.error(`Failed installing AWS package: ${error}`);
});

const elasticsearchUrlList = plugins.cloud?.setup?.elasticsearchUrl
? [plugins.cloud?.setup?.elasticsearchUrl]
: await getFallbackESUrl(services.esLegacyConfigService);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const synthtrace = getService('svlLogsSynthtraceClient');

// FLAKY: https://github.com/elastic/kibana/issues/193294
describe.skip('Onboarding Firehose Quickstart Flow', () => {
describe('Onboarding Firehose Quickstart Flow', () => {
before(async () => {
await PageObjects.svlCommonPage.loginAsAdmin(); // Onboarding requires admin role
await PageObjects.common.navigateToUrlWithBrowserHistory(
Expand Down

0 comments on commit ad53fcd

Please sign in to comment.