Merge branch 'ro_linting_rules_1' of github.com:cnasikas/kibana into …

…ro_linting_rules_1

x-pack/plugins/alerting/common/alert_schema/field_maps/component_template_from_field_map.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { ClusterPutComponentTemplateRequest } from '@elastic/elasticsearch/lib/api/types';
+import type { ClusterPutComponentTemplateRequest } from '@elastic/elasticsearch/lib/api/types';
 import { type FieldMap } from '@kbn/alerts-as-data-utils';
 import { mappingFromFieldMap } from './mapping_from_field_map';
 

x-pack/plugins/alerting/common/bulk_edit.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { Rule } from './rule';
+import type { Rule } from './rule';
 
 export type BulkEditSkipReason = 'RULE_NOT_MODIFIED';
 

x-pack/plugins/alerting/common/maintenance_window.ts

@@ -5,8 +5,8 @@
  * 2.0.
  */
 import type { IUiSettingsClient, Logger, SavedObjectsClientContract } from '@kbn/core/server';
-import { FilterStateStore } from '@kbn/es-query';
-import { RRuleParams } from './rrule_type';
+import type { FilterStateStore } from '@kbn/es-query';
+import type { RRuleParams } from './rrule_type';
 
 export enum MaintenanceWindowStatus {
   Running = 'running',

x-pack/plugins/alerting/common/parse_duration.ts

@@ -80,7 +80,7 @@ export function validateDurationSchema(duration: string) {
   if (duration.match(DAYS_REGEX)) {
     return;
   }
-  return 'string is not a valid duration: ' + duration;
+  return `string is not a valid duration: ${duration}`;
 }
 
 function isSeconds(duration: string) {

x-pack/plugins/alerting/common/routes/backfill/apis/delete/types/v1.ts

@@ -6,6 +6,6 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { deleteParamsSchemaV1 } from '..';
+import type { deleteParamsSchemaV1 } from '..';
 
 export type DeleteBackfillRequestParams = TypeOf<typeof deleteParamsSchemaV1>;

x-pack/plugins/alerting/common/routes/backfill/apis/find/types/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { findQuerySchemaV1, findResponseSchemaV1 } from '..';
+import type { findQuerySchemaV1, findResponseSchemaV1 } from '..';
 
 export type FindBackfillRequestQuery = TypeOf<typeof findQuerySchemaV1>;
 export type FindBackfillResponseBody = TypeOf<typeof findResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/backfill/apis/get/types/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { getParamsSchemaV1, getResponseSchemaV1 } from '..';
+import type { getParamsSchemaV1, getResponseSchemaV1 } from '..';
 
 export type GetBackfillRequestParams = TypeOf<typeof getParamsSchemaV1>;
 export type GetBackfillResponseBody = TypeOf<typeof getResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/backfill/apis/schedule/types/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { scheduleBodySchemaV1, scheduleResponseSchemaV1 } from '..';
+import type { scheduleBodySchemaV1, scheduleResponseSchemaV1 } from '..';
 
 export type ScheduleBackfillRequestBody = TypeOf<typeof scheduleBodySchemaV1>;
 export type ScheduleBackfillResponseBody = TypeOf<typeof scheduleResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/backfill/response/types/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { backfillResponseSchemaV1, errorResponseSchemaV1 } from '..';
+import type { backfillResponseSchemaV1, errorResponseSchemaV1 } from '..';
 
 export type BackfillResponse = TypeOf<typeof backfillResponseSchemaV1>;
 export type ErrorResponse = TypeOf<typeof errorResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/framework/apis/health/types/v1.ts

@@ -7,7 +7,7 @@
 
 import type { TypeOf } from '@kbn/config-schema';
 
-import { healthFrameworkResponseBodySchemaV1, healthFrameworkResponseSchemaV1 } from '..';
+import type { healthFrameworkResponseBodySchemaV1, healthFrameworkResponseSchemaV1 } from '..';
 
 export type HealthFrameworkResponseBody = TypeOf<typeof healthFrameworkResponseBodySchemaV1>;
 export type HealthFrameworkResponse = TypeOf<typeof healthFrameworkResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/maintenance_window/apis/archive/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { MaintenanceWindowResponseV1 } from '../../../response';
-import { archiveBodySchemaV1, archiveParamsSchemaV1 } from '..';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
+import type { archiveBodySchemaV1, archiveParamsSchemaV1 } from '..';
 
 export type ArchiveMaintenanceWindowRequestBody = TypeOf<typeof archiveBodySchemaV1>;
 export type ArchiveMaintenanceWindowRequestParams = TypeOf<typeof archiveParamsSchemaV1>;

x-pack/plugins/alerting/common/routes/maintenance_window/apis/bulk_get/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { MaintenanceWindowResponseV1 } from '../../../response';
-import { bulkGetBodySchemaV1 } from '..';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
+import type { bulkGetBodySchemaV1 } from '..';
 
 export type BulkGetMaintenanceWindowsRequestBody = TypeOf<typeof bulkGetBodySchemaV1>;
 

x-pack/plugins/alerting/common/routes/maintenance_window/apis/create/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { MaintenanceWindowResponseV1 } from '../../../response';
-import { createBodySchemaV1 } from '..';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
+import type { createBodySchemaV1 } from '..';
 
 export type CreateMaintenanceWindowRequestBody = TypeOf<typeof createBodySchemaV1>;
 

x-pack/plugins/alerting/common/routes/maintenance_window/apis/delete/types/v1.ts

@@ -6,6 +6,6 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { deleteParamsSchemaV1 } from '..';
+import type { deleteParamsSchemaV1 } from '..';
 
 export type DeleteMaintenanceWindowRequestParams = TypeOf<typeof deleteParamsSchemaV1>;

x-pack/plugins/alerting/common/routes/maintenance_window/apis/find/types/v1.ts

@@ -5,8 +5,8 @@
  * 2.0.
  */
 
-import { TypeOf } from '@kbn/config-schema';
-import {
+import type { TypeOf } from '@kbn/config-schema';
+import type {
   findMaintenanceWindowsResponseBodySchema,
   findMaintenanceWindowsRequestQuerySchema,
 } from '..';

x-pack/plugins/alerting/common/routes/maintenance_window/apis/finish/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { MaintenanceWindowResponseV1 } from '../../../response';
-import { finishParamsSchemaV1 } from '..';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
+import type { finishParamsSchemaV1 } from '..';
 
 export type FinishMaintenanceWindowRequestParams = TypeOf<typeof finishParamsSchemaV1>;
 

x-pack/plugins/alerting/common/routes/maintenance_window/apis/get/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { MaintenanceWindowResponseV1 } from '../../../response';
-import { getParamsSchemaV1 } from '..';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
+import type { getParamsSchemaV1 } from '..';
 
 export type GetMaintenanceWindowRequestParams = TypeOf<typeof getParamsSchemaV1>;
 

x-pack/plugins/alerting/common/routes/maintenance_window/apis/get_active/types/v1.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { MaintenanceWindowResponseV1 } from '../../../response';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
 
 export interface GetActiveMaintenanceWindowsResponse {
   body: MaintenanceWindowResponseV1[];

x-pack/plugins/alerting/common/routes/maintenance_window/apis/update/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { MaintenanceWindowResponseV1 } from '../../../response';
-import { updateParamsSchemaV1, updateBodySchemaV1 } from '..';
+import type { MaintenanceWindowResponseV1 } from '../../../response';
+import type { updateParamsSchemaV1, updateBodySchemaV1 } from '..';
 
 export type UpdateMaintenanceWindowRequestParams = TypeOf<typeof updateParamsSchemaV1>;
 export type UpdateMaintenanceWindowRequestBody = TypeOf<typeof updateBodySchemaV1>;

x-pack/plugins/alerting/common/routes/maintenance_window/response/types/v1.ts

@@ -6,6 +6,6 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { maintenanceWindowResponseSchemaV1 } from '..';
+import type { maintenanceWindowResponseSchemaV1 } from '..';
 
 export type MaintenanceWindowResponse = TypeOf<typeof maintenanceWindowResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/maintenance_window/shared/types/v1.ts

@@ -6,6 +6,6 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { maintenanceWindowCategoryIdsSchemaV1 } from '..';
+import type { maintenanceWindowCategoryIdsSchemaV1 } from '..';
 
 export type MaintenanceWindowCategoryIds = TypeOf<typeof maintenanceWindowCategoryIdsSchemaV1>;

x-pack/plugins/alerting/common/routes/r_rule/request/types/v1.ts

@@ -5,6 +5,6 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { rRuleRequestSchemaV1 } from '../..';
+import type { rRuleRequestSchemaV1 } from '../..';
 
 export type RRuleRequest = TypeOf<typeof rRuleRequestSchemaV1>;

x-pack/plugins/alerting/common/routes/r_rule/response/types/v1.ts

@@ -5,6 +5,6 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { rRuleResponseSchemaV1 } from '../..';
+import type { rRuleResponseSchemaV1 } from '../..';
 
 export type RRuleResponse = TypeOf<typeof rRuleResponseSchemaV1>;

x-pack/plugins/alerting/common/routes/r_rule/validation/validate_end_date/v1.ts

@@ -9,5 +9,4 @@ export const validateEndDate = (date: string) => {
   const parsedValue = Date.parse(date);
   if (isNaN(parsedValue)) return `Invalid date: ${date}`;
   if (parsedValue <= Date.now()) return `Invalid snooze date as it is in the past: ${date}`;
-  return;
 };

x-pack/plugins/alerting/common/routes/r_rule/validation/validate_start_date/v1.ts

@@ -8,5 +8,4 @@
 export const validateStartDate = (date: string) => {
   const parsedValue = Date.parse(date);
   if (isNaN(parsedValue)) return `Invalid date: ${date}`;
-  return;
 };

x-pack/plugins/alerting/common/routes/rule/apis/aggregate/types/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { aggregateRulesRequestBodySchemaV1, aggregateRulesResponseBodySchemaV1 } from '..';
+import type { aggregateRulesRequestBodySchemaV1, aggregateRulesResponseBodySchemaV1 } from '..';
 
 export type AggregateRulesRequestBody = TypeOf<typeof aggregateRulesRequestBodySchemaV1>;
 export type AggregateRulesResponseBody = TypeOf<typeof aggregateRulesResponseBodySchemaV1>;

x-pack/plugins/alerting/common/routes/rule/apis/bulk_delete/types/v1.ts

@@ -5,8 +5,8 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { bulkDeleteRulesRequestBodySchemaV1 } from '..';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { bulkDeleteRulesRequestBodySchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
 
 export interface BulkOperationError {
   message: string;

x-pack/plugins/alerting/common/routes/rule/apis/bulk_delete/validation/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import Boom from '@hapi/boom';
-import { BulkDeleteRulesRequestBody } from '..';
+import type { BulkDeleteRulesRequestBody } from '..';
 
 export const validateBulkDeleteRulesBody = (options: BulkDeleteRulesRequestBody) => {
   const filter = options.filter;

x-pack/plugins/alerting/common/routes/rule/apis/bulk_disable/types/v1.ts

@@ -5,8 +5,8 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { bulkDisableRulesRequestBodySchemaV1 } from '..';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { bulkDisableRulesRequestBodySchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
 
 export interface BulkOperationError {
   message: string;

x-pack/plugins/alerting/common/routes/rule/apis/bulk_disable/validation/v1.ts

@@ -6,7 +6,7 @@
  */
 
 import Boom from '@hapi/boom';
-import { BulkDisableRulesRequestBody } from '..';
+import type { BulkDisableRulesRequestBody } from '..';
 
 export const validateBulkDisableRulesBody = (options: BulkDisableRulesRequestBody) => {
   const filter = options.filter;

x-pack/plugins/alerting/common/routes/rule/apis/bulk_edit/types/v1.ts

@@ -5,8 +5,8 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
-import { bulkEditRulesRequestBodySchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { bulkEditRulesRequestBodySchemaV1 } from '..';
 
 export type BulkEditRulesRequestBody = TypeOf<typeof bulkEditRulesRequestBodySchemaV1>;
 

x-pack/plugins/alerting/common/routes/rule/apis/bulk_enable/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
-import { bulkEnableBodySchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { bulkEnableBodySchemaV1 } from '..';
 
 export type BulkEnableRulesRequestBody = TypeOf<typeof bulkEnableBodySchemaV1>;
 

x-pack/plugins/alerting/common/routes/rule/apis/bulk_untrack/types/v1.ts

@@ -5,6 +5,6 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { bulkUntrackBodySchemaV1 } from '..';
+import type { bulkUntrackBodySchemaV1 } from '..';
 
 export type BulkUntrackRequestBody = TypeOf<typeof bulkUntrackBodySchemaV1>;

x-pack/plugins/alerting/common/routes/rule/apis/bulk_untrack_by_query/types/v1.ts

@@ -5,6 +5,6 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { bulkUntrackByQueryBodySchemaV1 } from '..';
+import type { bulkUntrackByQueryBodySchemaV1 } from '..';
 
 export type BulkUntrackByQueryRequestBody = TypeOf<typeof bulkUntrackByQueryBodySchemaV1>;

x-pack/plugins/alerting/common/routes/rule/apis/clone/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
-import { cloneRuleRequestParamsSchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { cloneRuleRequestParamsSchemaV1 } from '..';
 
 export type CloneRuleRequestParams = TypeOf<typeof cloneRuleRequestParamsSchemaV1>;
 

x-pack/plugins/alerting/common/routes/rule/apis/create/types/v1.ts

@@ -5,8 +5,8 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
-import {
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type {
   actionSchemaV1,
   actionFrequencySchemaV1,
   createParamsSchemaV1,

x-pack/plugins/alerting/common/routes/rule/apis/delete/types/v1.ts

@@ -6,6 +6,6 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { deleteRuleRequestParamsSchemaV1 } from '..';
+import type { deleteRuleRequestParamsSchemaV1 } from '..';
 
 export type DeleteRuleRequestParams = TypeOf<typeof deleteRuleRequestParamsSchemaV1>;

x-pack/plugins/alerting/common/routes/rule/apis/disable/types/v1.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 import type { TypeOf } from '@kbn/config-schema';
-import { disableRuleRequestBodySchemaV1, disableRuleRequestParamsSchemaV1 } from '..';
+import type { disableRuleRequestBodySchemaV1, disableRuleRequestParamsSchemaV1 } from '..';
 
 export type DisableRuleRequestBody = TypeOf<typeof disableRuleRequestBodySchemaV1>;
 export type DisableRuleRequestParams = TypeOf<typeof disableRuleRequestParamsSchemaV1>;

x-pack/plugins/alerting/common/routes/rule/apis/enable/types/v1.ts

@@ -6,6 +6,6 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { enableRuleRequestParamsSchemaV1 } from '..';
+import type { enableRuleRequestParamsSchemaV1 } from '..';
 
 export type EnableRuleRequestParams = TypeOf<typeof enableRuleRequestParamsSchemaV1>;

x-pack/plugins/alerting/common/routes/rule/apis/find/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
-import { findRulesRequestQuerySchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { findRulesRequestQuerySchemaV1 } from '..';
 
 export type FindRulesRequestQuery = TypeOf<typeof findRulesRequestQuerySchemaV1>;
 

x-pack/plugins/alerting/common/routes/rule/apis/get/types/v1.ts

@@ -6,8 +6,8 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { RuleParamsV1, RuleResponseV1 } from '../../../response';
-import { getRuleRequestParamsSchemaV1 } from '..';
+import type { RuleParamsV1, RuleResponseV1 } from '../../../response';
+import type { getRuleRequestParamsSchemaV1 } from '..';
 
 export type GetRuleRequestParams = TypeOf<typeof getRuleRequestParamsSchemaV1>;
 

x-pack/plugins/alerting/common/routes/rule/apis/get_schedule_frequency/types/v1.ts

@@ -6,7 +6,10 @@
  */
 
 import type { TypeOf } from '@kbn/config-schema';
-import { getScheduleFrequencyResponseSchemaV1, getScheduleFrequencyResponseBodySchemaV1 } from '..';
+import type {
+  getScheduleFrequencyResponseSchemaV1,
+  getScheduleFrequencyResponseBodySchemaV1,
+} from '..';
 
 export type GetScheduleFrequencyResponseBody = TypeOf<
   typeof getScheduleFrequencyResponseBodySchemaV1